Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1380483004: Make global variable g_testing_build_time lazily created (Closed)

Created:
5 years, 2 months ago by ckulakowski
Modified:
5 years, 2 months ago
Reviewers:
Mustafa Acer, felt, meacer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make global variable g_testing_build_time lazily created. It's a fix for compilation error: ../../../../chromium/src/chrome/browser/ssl/ssl_error_classification.cc:121:12: error: declaration requires a global constructor [-Werror,-Wglobal-constructors] base::Time g_testing_build_time; Committed: https://crrev.com/120b9e508952cf61aafd29606499ad8a2c1c5026 Cr-Commit-Position: refs/heads/master@{#352410}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase to the newest master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/browser/ssl/ssl_error_classification.cc View 1 5 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 22 (8 generated)
ckulakowski
5 years, 2 months ago (2015-09-29 12:32:42 UTC) #2
Mustafa Acer
Nice catch, thanks for fixing this. Lgtm modulo a comment, for extra consistency. https://codereview.chromium.org/1380483004/diff/1/chrome/browser/ssl/ssl_error_classification.cc File ...
5 years, 2 months ago (2015-09-29 15:44:25 UTC) #4
ckulakowski
On 2015/09/29 15:44:25, Mustafa Acer wrote: > Nice catch, thanks for fixing this. Lgtm modulo ...
5 years, 2 months ago (2015-09-30 13:07:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380483004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380483004/1
5 years, 2 months ago (2015-10-01 06:10:20 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 2 months ago (2015-10-01 06:10:22 UTC) #9
meacer
On 2015/10/01 06:10:22, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
5 years, 2 months ago (2015-10-01 17:25:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380483004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380483004/1
5 years, 2 months ago (2015-10-01 17:27:53 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/104989) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 2 months ago (2015-10-01 17:30:44 UTC) #14
ckulakowski
5 years, 2 months ago (2015-10-05 07:57:33 UTC) #15
ckulakowski
On 2015/10/05 07:57:33, ckulakowski wrote: I've uploaded rebase to the newest master. Should I trybot ...
5 years, 2 months ago (2015-10-05 07:59:55 UTC) #16
meacer
On 2015/10/05 07:59:55, ckulakowski wrote: > On 2015/10/05 07:57:33, ckulakowski wrote: > > I've uploaded ...
5 years, 2 months ago (2015-10-05 17:21:31 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380483004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380483004/20001
5 years, 2 months ago (2015-10-05 19:36:10 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-05 20:27:32 UTC) #21
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 20:28:26 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/120b9e508952cf61aafd29606499ad8a2c1c5026
Cr-Commit-Position: refs/heads/master@{#352410}

Powered by Google App Engine
This is Rietveld 408576698