Make global variable g_testing_build_time lazily created

Make global variable g_testing_build_time lazily created.

It's a fix for compilation error:
../../../../chromium/src/chrome/browser/ssl/ssl_error_classification.cc:121:12: error: declaration requires a global constructor [-Werror,-Wglobal-constructors]
base::Time g_testing_build_time;

Committed: https://crrev.com/120b9e508952cf61aafd29606499ad8a2c1c5026
Cr-Commit-Position: refs/heads/master@{#352410}

[ckulakowski, 2015-09-29 12:32:33]

ckulakowski@opera.com changed reviewers:
+ felt@chromium.org, meacer@chromium.org

[Mustafa Acer, 2015-09-29 15:44:25]

meacer@google.com changed reviewers:
+ meacer@google.com

[Mustafa Acer, 2015-09-29 15:44:25]

Nice catch, thanks for fixing this. Lgtm modulo a comment, for extra
consistency.

https://codereview.chromium.org/1380483004/diff/1/chrome/browser/ssl/ssl_erro...
File chrome/browser/ssl/ssl_error_classification.cc (right):

https://codereview.chromium.org/1380483004/diff/1/chrome/browser/ssl/ssl_erro...
chrome/browser/ssl/ssl_error_classification.cc:121:
base::LazyInstance<base::Time> g_testing_build_time = LAZY_INSTANCE_INITIALIZER;
This could also simply be the timestamp in seconds, like uint64. That's actually
how it is in browser/ssl/ssl_error_handler so I think we should make them
consistent.

[ckulakowski, 2015-09-30 13:07:05]

On 2015/09/29 15:44:25, Mustafa Acer wrote:
> Nice catch, thanks for fixing this. Lgtm modulo a comment, for extra
> consistency.
> 
>
https://codereview.chromium.org/1380483004/diff/1/chrome/browser/ssl/ssl_erro...
> File chrome/browser/ssl/ssl_error_classification.cc (right):
> 
>
https://codereview.chromium.org/1380483004/diff/1/chrome/browser/ssl/ssl_erro...
> chrome/browser/ssl/ssl_error_classification.cc:121:
> base::LazyInstance<base::Time> g_testing_build_time =
LAZY_INSTANCE_INITIALIZER;
> This could also simply be the timestamp in seconds, like uint64. That's
actually
> how it is in browser/ssl/ssl_error_handler so I think we should make them
> consistent.

Actually it would be harder to make it int64. In ssl_error_handler.cc we use
base::TimeDelta which can be easily converted to/from int64. That's not the case
with base::Time which we use here.

[ckulakowski, 2015-10-01 06:10:06]

The CQ bit was checked by ckulakowski@opera.com

[commit-bot: I haz the power, 2015-10-01 06:10:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1380483004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1380483004/1

[commit-bot: I haz the power, 2015-10-01 06:10:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-01 06:10:22]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[meacer, 2015-10-01 17:25:39]

On 2015/10/01 06:10:22, commit-bot: I haz the power wrote:
> No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
> Even if an L-G-T-M may have been provided, it was from a non-committer,
> _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

LGTM from correct account this time

[meacer, 2015-10-01 17:26:05]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2015-10-01 17:27:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1380483004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1380483004/1

[commit-bot: I haz the power, 2015-10-01 17:30:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-01 17:30:44]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ckulakowski, 2015-10-05 07:59:55]

On 2015/10/05 07:57:33, ckulakowski wrote:

I've uploaded rebase to the newest master. Should I trybot again or I should
wait for additional review for rebase changes?

[meacer, 2015-10-05 17:21:31]

On 2015/10/05 07:59:55, ckulakowski wrote:
> On 2015/10/05 07:57:33, ckulakowski wrote:
> 
> I've uploaded rebase to the newest master. Should I trybot again or I should
> wait for additional review for rebase changes?

Still lgtm. In general if the diff hasn't changed much I add a note saying I
rebased and go with the trybots.

[ckulakowski, 2015-10-05 19:33:23]

The CQ bit was checked by ckulakowski@opera.com

[ckulakowski, 2015-10-05 19:33:24]

The patchset sent to the CQ was uploaded after l-g-t-m from meacer@google.com
Link to the patchset: https://codereview.chromium.org/1380483004/#ps20001
(title: "Rebase to the newest master.")

[commit-bot: I haz the power, 2015-10-05 19:36:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1380483004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1380483004/20001

[commit-bot: I haz the power, 2015-10-05 20:27:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-05 20:28:26]

Patchset 2 (id:??) landed as
https://crrev.com/120b9e508952cf61aafd29606499ad8a2c1c5026
Cr-Commit-Position: refs/heads/master@{#352410}