Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1349)

Issue 1380323005: Reland of Enable testing of WebRTC IP Permission Finch (Closed)

Created:
5 years, 2 months ago by guoweis_left_chromium
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Enable testing of WebRTC IP Permission Finch (patchset #2 id:40002 of https://codereview.chromium.org/1388913002/ ) Reason for revert: The original check in broke test and has been fixed by https://codereview.chromium.org/1381703006 Original issue's description: > Revert of Enable testing of WebRTC IP Permission Finch (patchset #1 id:1 of https://codereview.chromium.org/1380893005/ ) > > Reason for revert: > Speculative revert since we see failing tests in the WebRTC waterfall related to ICE. > > See > > https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/21950 > https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/43969 > > Original issue's description: > > Enable testing of WebRTC IP Permission Finch > > > > BUG=538815 > > > > Committed: https://crrev.com/efce5aa89bc5ac68f96184e44c4bb4b8c3a985e8 > > Cr-Commit-Position: refs/heads/master@{#352420} > > TBR=brettw@chromium.org,rkaplow@chromium.org,guoweis@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=538815 > > Committed: https://crrev.com/565e0d0173c5fb39441b773052de9f391060258b > Cr-Commit-Position: refs/heads/master@{#352570} TBR=brettw@chromium.org,rkaplow@chromium.org,henrika@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=538815 Committed: https://crrev.com/336786c5beb64348189f2f6cf9a5b2de14e37965 Cr-Commit-Position: refs/heads/master@{#352695}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config_android.json View 1 chunk +5 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_chromeos.json View 1 chunk +5 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_linux.json View 1 chunk +5 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_mac.json View 1 chunk +5 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_win.json View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
guoweis_left_chromium
Created Reland of Enable testing of WebRTC IP Permission Finch
5 years, 2 months ago (2015-10-06 20:58:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380323005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380323005/1
5 years, 2 months ago (2015-10-06 20:59:54 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 2 months ago (2015-10-06 20:59:55 UTC) #4
rkaplow
lgtm
5 years, 2 months ago (2015-10-06 21:46:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380323005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380323005/1
5 years, 2 months ago (2015-10-06 21:48:33 UTC) #7
guoweis_left_chromium
On 2015/10/06 21:48:33, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years, 2 months ago (2015-10-06 21:53:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380323005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380323005/1
5 years, 2 months ago (2015-10-06 21:54:10 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 21:56:31 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/336786c5beb64348189f2f6cf9a5b2de14e37965 Cr-Commit-Position: refs/heads/master@{#352695}
5 years, 2 months ago (2015-10-06 21:57:25 UTC) #14
guoweis_left_chromium
5 years, 2 months ago (2015-10-06 23:04:51 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1385323003/ by guoweis@chromium.org.

The reason for reverting is: Hmm, this still causes the failure. When I tested
it, I could repro it but not anymore after the checkin I mentioned.

Revert it again to do more investigation..

Powered by Google App Engine
This is Rietveld 408576698