Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 138023008: Revert 246117 "gn: Default is_clang to true on iOS." (Closed)

Created:
6 years, 11 months ago by Nico
Modified:
6 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 246117 "gn: Default is_clang to true on iOS." This isn't correct for the xcode iOS builder. > gn: Default is_clang to true on iOS. > > Mirrors this condition in build/common.gypi: > > ['OS == "ios"', { > # ... > > # Enable clang and host builds when generating with ninja-ios. > 'conditions': [ > ['"<(GENERATOR)"=="ninja"', { > 'clang%': 1, > 'host_os%': "mac", > }] > ], > }], > > BUG=336531 > TBR=brettw@chromium.org > > Review URL: https://codereview.chromium.org/143323008 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246144

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M trunk/src/build/config/BUILDCONFIG.gn View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
6 years, 11 months ago (2014-01-21 22:42:24 UTC) #1
Nico
6 years, 11 months ago (2014-01-21 22:42:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r246144.

Powered by Google App Engine
This is Rietveld 408576698