Issue 143323008: gn: Default is_clang to true on iOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 143323008: gn: Default is_clang to true on iOS. (Closed)

Created:
6 years, 11 months ago by Nico

Modified:
6 years, 11 months ago

Reviewers:
brettw, justincohen

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gn: Default is_clang to true on iOS. Mirrors this condition in build/common.gypi: ['OS == "ios"', { # ... # Enable clang and host builds when generating with ninja-ios. 'conditions': [ ['"<(GENERATOR)"=="ninja"', { 'clang%': 1, 'host_os%': "mac", }] ], }], BUG=336531 TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246117

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	build/config/BUILDCONFIG.gn	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

6 years, 11 months ago (2014-01-21 21:34:41 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r246117 (presubmit successful).

Expand Messages | Collapse Messages