Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: pkg/analysis_server/test/services/completion/completion_test_util.dart

Issue 1380223003: Issue 23694. Include 'docSummary' and 'docComplete' into CompletionSuggestion. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: tweak Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/completion_test_util.dart
diff --git a/pkg/analysis_server/test/services/completion/completion_test_util.dart b/pkg/analysis_server/test/services/completion/completion_test_util.dart
index 34397e356a28890502c82c997b92f3afab169067..237868960e57a71d8d0094a04b0604964e254452 100644
--- a/pkg/analysis_server/test/services/completion/completion_test_util.dart
+++ b/pkg/analysis_server/test/services/completion/completion_test_util.dart
@@ -120,7 +120,9 @@ abstract class AbstractCompletionTest extends AbstractContextTest {
bool isDeprecated: false,
bool isPotential: false,
String elemFile,
- int elemOffset}) {
+ int elemOffset,
+ docCompleteMatcher,
+ docSummaryMatcher}) {
CompletionSuggestion cs =
getSuggest(completion: completion, csKind: csKind, elemKind: elemKind);
if (cs == null) {
@@ -152,6 +154,12 @@ abstract class AbstractCompletionTest extends AbstractContextTest {
if (elemOffset != null) {
expect(cs.element.location.offset, elemOffset);
}
+ if (docCompleteMatcher != null) {
+ expect(cs.docComplete, docCompleteMatcher);
+ }
+ if (docSummaryMatcher != null) {
+ expect(cs.docSummary, docSummaryMatcher);
+ }
return cs;
}
@@ -161,14 +169,18 @@ abstract class AbstractCompletionTest extends AbstractContextTest {
CompletionSuggestionKind kind: CompletionSuggestionKind.INVOCATION,
bool isDeprecated: false,
String elemFile,
- int elemOffset}) {
+ int elemOffset,
+ docCompleteMatcher,
+ docSummaryMatcher}) {
CompletionSuggestion cs = assertSuggest(name,
csKind: kind,
relevance: relevance,
importUri: importUri,
isDeprecated: isDeprecated,
elemFile: elemFile,
- elemOffset: elemOffset);
+ elemOffset: elemOffset,
+ docCompleteMatcher: docCompleteMatcher,
+ docSummaryMatcher: docSummaryMatcher);
protocol.Element element = cs.element;
expect(element, isNotNull);
expect(element.kind, equals(protocol.ElementKind.CLASS));
@@ -236,12 +248,16 @@ abstract class AbstractCompletionTest extends AbstractContextTest {
{CompletionSuggestionKind kind: CompletionSuggestionKind.INVOCATION,
bool deprecated: false,
int relevance: DART_RELEVANCE_DEFAULT,
- String importUri}) {
+ String importUri,
+ docCompleteMatcher,
+ docSummaryMatcher}) {
CompletionSuggestion cs = assertSuggest(name,
csKind: kind,
relevance: relevance,
importUri: importUri,
- isDeprecated: deprecated);
+ isDeprecated: deprecated,
+ docCompleteMatcher: docCompleteMatcher,
+ docSummaryMatcher: docSummaryMatcher);
expect(cs.returnType, returnType != null ? returnType : 'dynamic');
protocol.Element element = cs.element;
expect(element, isNotNull);
@@ -338,12 +354,16 @@ abstract class AbstractCompletionTest extends AbstractContextTest {
{int relevance: DART_RELEVANCE_DEFAULT,
String importUri,
CompletionSuggestionKind kind: CompletionSuggestionKind.INVOCATION,
- bool isDeprecated: false}) {
+ bool isDeprecated: false,
+ docCompleteMatcher,
+ docSummaryMatcher}) {
CompletionSuggestion cs = assertSuggest(name,
csKind: kind,
relevance: relevance,
importUri: importUri,
- isDeprecated: isDeprecated);
+ isDeprecated: isDeprecated,
+ docCompleteMatcher: docCompleteMatcher,
+ docSummaryMatcher: docSummaryMatcher);
expect(cs.declaringType, equals(declaringType));
expect(cs.returnType, returnType != null ? returnType : 'dynamic');
protocol.Element element = cs.element;

Powered by Google App Engine
This is Rietveld 408576698