Issue 138003013: Remove unnecessary maybeDOMWrapper from indexed/named property getters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 138003013: Remove unnecessary maybeDOMWrapper from indexed/named property getters (Closed)

Created:
6 years, 11 months ago by Nils Barth (inactive)

Modified:
6 years, 11 months ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive, kouhei (in TOK)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove unnecessary maybeDOMWrapper from indexed/named property getters The following call is unnecessary: ASSERT(V8DOMWrapper::maybeDOMWrapper(info.Holder())); ...since info.Holder() is guaranteed to return a DOMWrapper. ...per request of haraken: https://codereview.chromium.org/148083004/#msg3 TBR=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165838

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -7 lines)			Patch
M	Source/bindings/scripts/code_generator_v8.pm	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestEventTarget.cpp	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestInterface.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestObject.cpp	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/138003013/1

6 years, 11 months ago (2014-01-27 06:58:35 UTC) #2

Message was sent while issue was closed.

Change committed as 165838

Expand Messages | Collapse Messages