Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 138003013: Remove unnecessary maybeDOMWrapper from indexed/named property getters (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestEventTarget.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org> 1 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
2 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com> 2 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
3 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> 3 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org> 4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
5 # Copyright (C) 2006 Apple Computer, Inc. 5 # Copyright (C) 2006 Apple Computer, Inc.
6 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc. 6 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
8 # Copyright (C) Research In Motion Limited 2010. All rights reserved. 8 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
9 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 # Copyright (C) 2012 Ericsson AB. All rights reserved. 10 # Copyright (C) 2012 Ericsson AB. All rights reserved.
(...skipping 3638 matching lines...) Expand 10 before | Expand all | Expand 10 after
3649 my $returnType = $indexedGetterFunction->type; 3649 my $returnType = $indexedGetterFunction->type;
3650 my $nativeType = GetNativeType($returnType); 3650 my $nativeType = GetNativeType($returnType);
3651 my $nativeValue = "element"; 3651 my $nativeValue = "element";
3652 $nativeValue .= ".release()" if (IsRefPtrType($returnType)); 3652 $nativeValue .= ".release()" if (IsRefPtrType($returnType));
3653 my $isNull = GenerateIsNullExpression($returnType, "element"); 3653 my $isNull = GenerateIsNullExpression($returnType, "element");
3654 my $returnJSValueCode = NativeToJSValue($indexedGetterFunction->type, $index edGetterFunction->extendedAttributes, $nativeValue, " ", "", "info.GetIsolate ()", "info", "collection", "", "return"); 3654 my $returnJSValueCode = NativeToJSValue($indexedGetterFunction->type, $index edGetterFunction->extendedAttributes, $nativeValue, " ", "", "info.GetIsolate ()", "info", "collection", "", "return");
3655 my $raisesExceptions = $indexedGetterFunction->extendedAttributes->{"RaisesE xception"}; 3655 my $raisesExceptions = $indexedGetterFunction->extendedAttributes->{"RaisesE xception"};
3656 my $methodCallCode = GenerateMethodCall($returnType, "element", "collection- >${methodName}", "index", $raisesExceptions); 3656 my $methodCallCode = GenerateMethodCall($returnType, "element", "collection- >${methodName}", "index", $raisesExceptions);
3657 my $getterCode = "static void indexedPropertyGetter(uint32_t index, const v8 ::PropertyCallbackInfo<v8::Value>& info)\n"; 3657 my $getterCode = "static void indexedPropertyGetter(uint32_t index, const v8 ::PropertyCallbackInfo<v8::Value>& info)\n";
3658 $getterCode .= "{\n"; 3658 $getterCode .= "{\n";
3659 $getterCode .= " ASSERT(V8DOMWrapper::maybeDOMWrapper(info.Holder()));\n" ;
3660 $getterCode .= " ${implClassName}* collection = ${v8ClassName}::toNative( info.Holder());\n"; 3659 $getterCode .= " ${implClassName}* collection = ${v8ClassName}::toNative( info.Holder());\n";
3661 if ($raisesExceptions) { 3660 if ($raisesExceptions) {
3662 $getterCode .= " ExceptionState exceptionState(info.Holder(), info.Ge tIsolate());\n"; 3661 $getterCode .= " ExceptionState exceptionState(info.Holder(), info.Ge tIsolate());\n";
3663 } 3662 }
3664 $getterCode .= $methodCallCode . "\n"; 3663 $getterCode .= $methodCallCode . "\n";
3665 if ($raisesExceptions) { 3664 if ($raisesExceptions) {
3666 $getterCode .= " if (exceptionState.throwIfNeeded())\n"; 3665 $getterCode .= " if (exceptionState.throwIfNeeded())\n";
3667 $getterCode .= " return;\n"; 3666 $getterCode .= " return;\n";
3668 } 3667 }
3669 if (IsUnionType($returnType)) { 3668 if (IsUnionType($returnType)) {
(...skipping 348 matching lines...) Expand 10 before | Expand all | Expand 10 after
4018 $code .= "{\n"; 4017 $code .= "{\n";
4019 if (!$namedGetterFunction->extendedAttributes->{"OverrideBuiltins"}) { 4018 if (!$namedGetterFunction->extendedAttributes->{"OverrideBuiltins"}) {
4020 $code .= " if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(n ame).IsEmpty())\n"; 4019 $code .= " if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(n ame).IsEmpty())\n";
4021 $code .= " return;\n"; 4020 $code .= " return;\n";
4022 $code .= " if (info.Holder()->HasRealNamedCallbackProperty(name))\n"; 4021 $code .= " if (info.Holder()->HasRealNamedCallbackProperty(name))\n";
4023 $code .= " return;\n"; 4022 $code .= " return;\n";
4024 $code .= " if (info.Holder()->HasRealNamedProperty(name))\n"; 4023 $code .= " if (info.Holder()->HasRealNamedProperty(name))\n";
4025 $code .= " return;\n"; 4024 $code .= " return;\n";
4026 } 4025 }
4027 $code .= "\n"; 4026 $code .= "\n";
4028 $code .= " ASSERT(V8DOMWrapper::maybeDOMWrapper(info.Holder()));\n";
4029 $code .= " ${implClassName}* collection = ${v8ClassName}::toNative(info.H older());\n"; 4027 $code .= " ${implClassName}* collection = ${v8ClassName}::toNative(info.H older());\n";
4030 $code .= " AtomicString propertyName = toCoreAtomicString(name);\n"; 4028 $code .= " AtomicString propertyName = toCoreAtomicString(name);\n";
4031 if ($raisesExceptions) { 4029 if ($raisesExceptions) {
4032 $code .= " ExceptionState exceptionState(info.Holder(), info.GetIsola te());\n"; 4030 $code .= " ExceptionState exceptionState(info.Holder(), info.GetIsola te());\n";
4033 } 4031 }
4034 $code .= $methodCallCode . "\n"; 4032 $code .= $methodCallCode . "\n";
4035 if ($raisesExceptions) { 4033 if ($raisesExceptions) {
4036 $code .= " if (exceptionState.throwIfNeeded())\n"; 4034 $code .= " if (exceptionState.throwIfNeeded())\n";
4037 $code .= " return;\n"; 4035 $code .= " return;\n";
4038 } 4036 }
(...skipping 2361 matching lines...) Expand 10 before | Expand all | Expand 10 after
6400 if ($parameter->type eq "SerializedScriptValue") { 6398 if ($parameter->type eq "SerializedScriptValue") {
6401 return 1; 6399 return 1;
6402 } elsif (IsIntegerType($parameter->type)) { 6400 } elsif (IsIntegerType($parameter->type)) {
6403 return 1; 6401 return 1;
6404 } 6402 }
6405 } 6403 }
6406 return 0; 6404 return 0;
6407 } 6405 }
6408 6406
6409 1; 6407 1;
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestEventTarget.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698