Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 138003005: Move dispatchChangeEvent to HTMLFormControlElement (Closed)

Created:
6 years, 11 months ago by rwlbuis
Modified:
6 years, 11 months ago
Reviewers:
Inactive
CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move dispatchChangeEvent to HTMLFormControlElement Also devirtualize it along with dispatchInputEvent. Based on http://trac.webkit.org/changeset/150805 by Andreas Kling. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165114

Patch Set 1 #

Patch Set 2 : Retry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M Source/core/dom/Node.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/HTMLFormControlElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/FileInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
rwlbuis
I stumbled on the virtual not being needed for dispatchChangeEvent, and then I noticed there ...
6 years, 11 months ago (2014-01-14 22:34:09 UTC) #1
Inactive
On 2014/01/14 22:34:09, rwlbuis wrote: > I stumbled on the virtual not being needed for ...
6 years, 11 months ago (2014-01-14 23:03:15 UTC) #2
rwlbuis
On 2014/01/14 23:03:15, Chris Dumez wrote: > On 2014/01/14 22:34:09, rwlbuis wrote: > > I ...
6 years, 11 months ago (2014-01-14 23:13:38 UTC) #3
Inactive
lgtm but please update the Changelog to indicate that you are devirtualizing Node::dispatchInputEvent() as well. ...
6 years, 11 months ago (2014-01-14 23:15:43 UTC) #4
rwlbuis
On 2014/01/14 23:15:43, Chris Dumez wrote: > lgtm but please update the Changelog to indicate ...
6 years, 11 months ago (2014-01-14 23:18:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/138003005/130001
6 years, 11 months ago (2014-01-14 23:21:07 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-15 09:47:00 UTC) #7
Message was sent while issue was closed.
Change committed as 165114

Powered by Google App Engine
This is Rietveld 408576698