Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Side by Side Diff: Source/core/html/HTMLTextFormControlElement.cpp

Issue 138003005: Move dispatchChangeEvent to HTMLFormControlElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Retry Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLFormControlElement.cpp ('k') | Source/core/html/forms/FileInputType.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 String HTMLTextFormControlElement::selectedText() const 185 String HTMLTextFormControlElement::selectedText() const
186 { 186 {
187 if (!isTextFormControl()) 187 if (!isTextFormControl())
188 return String(); 188 return String();
189 return value().substring(selectionStart(), selectionEnd() - selectionStart() ); 189 return value().substring(selectionStart(), selectionEnd() - selectionStart() );
190 } 190 }
191 191
192 void HTMLTextFormControlElement::dispatchFormControlChangeEvent() 192 void HTMLTextFormControlElement::dispatchFormControlChangeEvent()
193 { 193 {
194 if (m_textAsOfLastFormControlChangeEvent != value()) { 194 if (m_textAsOfLastFormControlChangeEvent != value()) {
195 HTMLElement::dispatchChangeEvent(); 195 dispatchChangeEvent();
196 setTextAsOfLastFormControlChangeEvent(value()); 196 setTextAsOfLastFormControlChangeEvent(value());
197 } 197 }
198 setChangedSinceLastFormControlChangeEvent(false); 198 setChangedSinceLastFormControlChangeEvent(false);
199 } 199 }
200 200
201 static inline bool hasVisibleTextArea(RenderObject* renderer, HTMLElement* inner Text) 201 static inline bool hasVisibleTextArea(RenderObject* renderer, HTMLElement* inner Text)
202 { 202 {
203 ASSERT(renderer); 203 ASSERT(renderer);
204 return renderer->style()->visibility() != HIDDEN && innerText && innerText-> renderer() && innerText->renderBox()->height(); 204 return renderer->style()->visibility() != HIDDEN && innerText && innerText-> renderer() && innerText->renderBox()->height();
205 } 205 }
(...skipping 444 matching lines...) Expand 10 before | Expand all | Expand 10 after
650 650
651 return "ltr"; 651 return "ltr";
652 } 652 }
653 653
654 HTMLElement* HTMLTextFormControlElement::innerTextElement() const 654 HTMLElement* HTMLTextFormControlElement::innerTextElement() const
655 { 655 {
656 return toHTMLElement(userAgentShadowRoot()->getElementById(ShadowElementName s::innerEditor())); 656 return toHTMLElement(userAgentShadowRoot()->getElementById(ShadowElementName s::innerEditor()));
657 } 657 }
658 658
659 } // namespace Webcore 659 } // namespace Webcore
OLDNEW
« no previous file with comments | « Source/core/html/HTMLFormControlElement.cpp ('k') | Source/core/html/forms/FileInputType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698