Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 137993020: (Try 2) InstantExtended: remove dead code related to the non-cacheable NTP. (Closed)

Created:
6 years, 11 months ago by kmadhusu
Modified:
6 years, 11 months ago
Reviewers:
samarth, sky
CC:
chromium-reviews, davidben+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, tburkard+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, yoshiki+watch_chromium.org, dominich, gavinp+prer_chromium.org, dominich+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, chromium-apps-reviews_chromium.org, kmadhusu+watch_chromium.org, Jered
Visibility:
Public.

Description

(Try 2) InstantExtended: remove dead code related to the non-cacheable NTP. Original CL: crrev.com/132733002 Reverted CL: crrev.com/135903002 TBR=samarth@chromium.org,sky@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245636

Patch Set 1 : crrev.com/132733002 patch #

Patch Set 2 : Disable InstantPolicyTests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -1978 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/search/instant_service.h View 7 chunks +1 line, -33 lines 0 comments Download
M chrome/browser/search/instant_service.cc View 5 chunks +0 lines, -49 lines 0 comments Download
M chrome/browser/search/instant_service_unittest.cc View 4 chunks +0 lines, -38 lines 0 comments Download
M chrome/browser/search/search.h View 2 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/search/search.cc View 7 chunks +3 lines, -75 lines 0 comments Download
M chrome/browser/search/search_unittest.cc View 11 chunks +16 lines, -64 lines 0 comments Download
M chrome/browser/task_manager/extension_process_resource_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/task_manager/panel_resource_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/task_manager/tab_contents_resource_provider.cc View 6 chunks +1 line, -15 lines 0 comments Download
M chrome/browser/task_manager/task_manager_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_util.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/task_manager/task_manager_util_unittest.cc View 1 chunk +8 lines, -11 lines 0 comments Download
M chrome/browser/ui/browser_instant_controller.h View 3 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/ui/browser_instant_controller.cc View 4 chunks +1 line, -70 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 6 chunks +7 lines, -20 lines 0 comments Download
M chrome/browser/ui/search/instant_controller.h View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/search/instant_controller.cc View 2 chunks +0 lines, -34 lines 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 1 21 chunks +41 lines, -133 lines 0 comments Download
M chrome/browser/ui/search/instant_extended_manual_interactive_uitest.cc View 2 chunks +1 line, -28 lines 0 comments Download
D chrome/browser/ui/search/instant_loader.h View 1 chunk +0 lines, -119 lines 0 comments Download
D chrome/browser/ui/search/instant_loader.cc View 1 chunk +0 lines, -176 lines 0 comments Download
D chrome/browser/ui/search/instant_ntp.h View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/ui/search/instant_ntp.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/ui/search/instant_ntp_prerenderer.h View 1 chunk +0 lines, -154 lines 0 comments Download
D chrome/browser/ui/search/instant_ntp_prerenderer.cc View 1 chunk +0 lines, -269 lines 0 comments Download
D chrome/browser/ui/search/instant_ntp_prerenderer_unittest.cc View 1 chunk +0 lines, -244 lines 0 comments Download
M chrome/browser/ui/search/instant_page.h View 2 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/ui/search/instant_page.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M chrome/browser/ui/search/instant_page_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/search/instant_test_utils.h View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/search/instant_test_utils.cc View 7 chunks +5 lines, -36 lines 0 comments Download
D chrome/browser/ui/search/instant_unload_handler.h View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/ui/search/instant_unload_handler.cc View 1 chunk +0 lines, -106 lines 0 comments Download
M chrome/browser/ui/search/local_ntp_browsertest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
A + chrome/test/data/instant_extended_ntp.html View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/137993020/100001
6 years, 11 months ago (2014-01-16 22:00:26 UTC) #1
kmadhusu
Disabled flaky tests. Will enable them in the follow up CL. Thanks.
6 years, 11 months ago (2014-01-16 22:01:43 UTC) #2
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=247629
6 years, 11 months ago (2014-01-16 23:33:57 UTC) #3
samarth
lgtm thanks!
6 years, 11 months ago (2014-01-17 01:29:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/137993020/100001
6 years, 11 months ago (2014-01-17 17:43:41 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 22:11:57 UTC) #6
Message was sent while issue was closed. 
Change committed as 245636

Powered by Google App Engine
This is Rietveld 408576698