Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: chrome/browser/ui/search/local_ntp_browsertest.cc

Issue 137993020: (Try 2) InstantExtended: remove dead code related to the non-cacheable NTP. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Disable InstantPolicyTests Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/prefs/pref_service.h" 5 #include "base/prefs/pref_service.h"
6 #include "base/strings/utf_string_conversions.h" 6 #include "base/strings/utf_string_conversions.h"
7 #include "chrome/browser/browser_process.h" 7 #include "chrome/browser/browser_process.h"
8 #include "chrome/browser/search/search.h" 8 #include "chrome/browser/search/search.h"
9 #include "chrome/browser/ui/search/instant_test_utils.h" 9 #include "chrome/browser/ui/search/instant_test_utils.h"
10 #include "chrome/browser/ui/tabs/tab_strip_model.h" 10 #include "chrome/browser/ui/tabs/tab_strip_model.h"
11 #include "chrome/common/pref_names.h" 11 #include "chrome/common/pref_names.h"
12 #include "chrome/common/url_constants.h" 12 #include "chrome/common/url_constants.h"
13 #include "chrome/test/base/in_process_browser_test.h" 13 #include "chrome/test/base/in_process_browser_test.h"
14 #include "chrome/test/base/ui_test_utils.h" 14 #include "chrome/test/base/ui_test_utils.h"
15 #include "content/public/browser/web_contents.h" 15 #include "content/public/browser/web_contents.h"
16 #include "ui/base/resource/resource_bundle.h" 16 #include "ui/base/resource/resource_bundle.h"
17 17
18 class LocalNTPTest : public InProcessBrowserTest, 18 class LocalNTPTest : public InProcessBrowserTest,
19 public InstantTestBase { 19 public InstantTestBase {
20 public: 20 public:
21 LocalNTPTest() {} 21 LocalNTPTest() {}
22 22
23 protected: 23 protected:
24 virtual void SetUpInProcessBrowserTestFixture() OVERRIDE { 24 virtual void SetUpInProcessBrowserTestFixture() OVERRIDE {
25 ASSERT_TRUE(https_test_server().Start()); 25 ASSERT_TRUE(https_test_server().Start());
26 GURL instant_url = https_test_server().GetURL( 26 GURL instant_url = https_test_server().GetURL(
27 "files/instant_extended.html?strk=1&");
28 GURL ntp_url = https_test_server().GetURL(
27 "files/local_ntp_browsertest.html?strk=1&"); 29 "files/local_ntp_browsertest.html?strk=1&");
28 InstantTestBase::Init(instant_url, false); 30 InstantTestBase::Init(instant_url, ntp_url, false);
29 } 31 }
30 }; 32 };
31 33
32 // Flaky: crbug.com/267117 34 // Flaky: crbug.com/267117
33 IN_PROC_BROWSER_TEST_F(LocalNTPTest, DISABLED_LocalNTPJavascriptTest) { 35 IN_PROC_BROWSER_TEST_F(LocalNTPTest, DISABLED_LocalNTPJavascriptTest) {
34 ASSERT_NO_FATAL_FAILURE(SetupInstant(browser())); 36 ASSERT_NO_FATAL_FAILURE(SetupInstant(browser()));
35 FocusOmniboxAndWaitForInstantNTPSupport(); 37 FocusOmnibox();
36 38
37 ui_test_utils::NavigateToURLWithDisposition( 39 ui_test_utils::NavigateToURLWithDisposition(
38 browser(), 40 browser(),
39 instant_url(), 41 instant_url(),
40 NEW_FOREGROUND_TAB, 42 NEW_FOREGROUND_TAB,
41 ui_test_utils::BROWSER_TEST_WAIT_FOR_TAB | 43 ui_test_utils::BROWSER_TEST_WAIT_FOR_TAB |
42 ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION); 44 ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
43 content::WebContents* active_tab = 45 content::WebContents* active_tab =
44 browser()->tab_strip_model()->GetActiveWebContents(); 46 browser()->tab_strip_model()->GetActiveWebContents();
45 ASSERT_TRUE(chrome::IsInstantNTP(active_tab)); 47 ASSERT_TRUE(chrome::IsInstantNTP(active_tab));
(...skipping 12 matching lines...) Expand all
58 // Switch browser language to French. 60 // Switch browser language to French.
59 std::string loaded_locale = 61 std::string loaded_locale =
60 ui::ResourceBundle::GetSharedInstance().ReloadLocaleResources("fr"); 62 ui::ResourceBundle::GetSharedInstance().ReloadLocaleResources("fr");
61 EXPECT_EQ("fr", loaded_locale); 63 EXPECT_EQ("fr", loaded_locale);
62 g_browser_process->SetApplicationLocale(loaded_locale); 64 g_browser_process->SetApplicationLocale(loaded_locale);
63 PrefService* prefs = g_browser_process->local_state(); 65 PrefService* prefs = g_browser_process->local_state();
64 prefs->SetString(prefs::kApplicationLocale, loaded_locale); 66 prefs->SetString(prefs::kApplicationLocale, loaded_locale);
65 67
66 // Setup Instant. 68 // Setup Instant.
67 ASSERT_NO_FATAL_FAILURE(SetupInstant(browser())); 69 ASSERT_NO_FATAL_FAILURE(SetupInstant(browser()));
68 FocusOmniboxAndWaitForInstantNTPSupport(); 70 FocusOmnibox();
69 71
70 // Open a new tab. 72 // Open a new tab.
71 ui_test_utils::NavigateToURLWithDisposition( 73 ui_test_utils::NavigateToURLWithDisposition(
72 browser(), 74 browser(),
73 GURL(chrome::kChromeUINewTabURL), 75 GURL(chrome::kChromeUINewTabURL),
74 NEW_FOREGROUND_TAB, 76 NEW_FOREGROUND_TAB,
75 ui_test_utils::BROWSER_TEST_WAIT_FOR_TAB | 77 ui_test_utils::BROWSER_TEST_WAIT_FOR_TAB |
76 ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION); 78 ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
77 79
78 // Verify that the NTP is in French. 80 // Verify that the NTP is in French.
79 content::WebContents* active_tab = 81 content::WebContents* active_tab =
80 browser()->tab_strip_model()->GetActiveWebContents(); 82 browser()->tab_strip_model()->GetActiveWebContents();
81 EXPECT_EQ(base::ASCIIToUTF16("Nouvel onglet"), active_tab->GetTitle()); 83 EXPECT_EQ(base::ASCIIToUTF16("Nouvel onglet"), active_tab->GetTitle());
82 } 84 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/search/instant_unload_handler.cc ('k') | chrome/browser/ui/search/search_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698