Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 137993010: Added support for properly building and running isolates in recipes. (Closed)

Created:
6 years, 11 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 11 months ago
Reviewers:
iannucci
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, xusydoc+watch_chromium.org, kjellander+cc_chromium.org, Vadim Sh., Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Visibility:
Public.

Description

Added support for properly building and running isolates in recipes. (Re-land of https://codereview.chromium.org/132853003/ after lab machines were whitelisted.) Switched the GPU recipe to run gl_tests via an isolate. Will convert remaining tests to run via isolates once this is working well on the bots. In addition to recipes_test, tested by running gpu/build_and_test recipe locally on Linux. Isolate is properly uploaded to the server during the build steps and executed via run_isolated.py during the test steps. BUG=321878 TBR=iannucci@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=244799

Patch Set 1 #

Patch Set 2 : Added missed files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1739 lines, -307 lines) Patch
M scripts/slave/recipe_modules/gpu/api.py View 4 chunks +16 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/isolate/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/isolate/api.py View 2 chunks +57 lines, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.py View 1 chunk +6 lines, -1 line 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_debug.json View 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_debug_blink.json View 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_debug_tryserver.json View 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_release.json View 3 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_release_blink.json View 3 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/linux_release_tryserver.json View 3 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_debug.json View 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_debug_blink.json View 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_debug_tryserver.json View 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release.json View 3 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_blink.json View 3 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_git.json View 3 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_skip_checkout.json View 3 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_skip_compile.json View 12 chunks +33 lines, -28 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_tryserver.json View 3 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/mac_release_tryserver_blink.json View 3 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_debug.json View 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_debug_blink.json View 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_debug_tryserver.json View 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_release.json View 3 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_release_blink.json View 3 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_test.expected/win_release_tryserver.json View 3 chunks +10 lines, -5 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.py View 1 chunk +11 lines, -9 lines 0 comments Download
A + scripts/slave/recipes/gpu/build_and_upload.expected/linux_debug.json View 1 5 chunks +8 lines, -8 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/linux_release.json View 2 chunks +4 lines, -4 lines 0 comments Download
A + scripts/slave/recipes/gpu/build_and_upload.expected/mac_debug.json View 1 5 chunks +8 lines, -8 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/mac_release.json View 2 chunks +4 lines, -4 lines 0 comments Download
A + scripts/slave/recipes/gpu/build_and_upload.expected/win_debug.json View 1 5 chunks +8 lines, -8 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/win_release.json View 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipes/gpu/download_and_test.py View 1 chunk +19 lines, -14 lines 0 comments Download
A scripts/slave/recipes/gpu/download_and_test.expected/linux_debug.json View 1 1 chunk +429 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/download_and_test.expected/linux_release.json View 15 chunks +45 lines, -40 lines 0 comments Download
A scripts/slave/recipes/gpu/download_and_test.expected/mac_debug.json View 1 1 chunk +408 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/download_and_test.expected/mac_release.json View 15 chunks +45 lines, -40 lines 0 comments Download
A scripts/slave/recipes/gpu/download_and_test.expected/win_debug.json View 1 1 chunk +432 lines, -0 lines 0 comments Download
M scripts/slave/recipes/gpu/download_and_test.expected/win_release.json View 15 chunks +45 lines, -40 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ken Russell (switch to Gerrit)
FYI
6 years, 11 months ago (2014-01-14 20:32:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/137993010/1
6 years, 11 months ago (2014-01-14 20:33:11 UTC) #2
commit-bot: I haz the power
Presubmit check for 137993010-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 11 months ago (2014-01-14 20:34:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/137993010/50001
6 years, 11 months ago (2014-01-14 20:43:40 UTC) #4
commit-bot: I haz the power
Change committed as 244799
6 years, 11 months ago (2014-01-14 20:44:55 UTC) #5
bajones
6 years, 11 months ago (2014-01-14 21:46:50 UTC) #6
Message was sent while issue was closed.
It appears that this is causing issues on the bots. All three Windows Release
testers are failing gl_tests with some variation of:

ERROR net(429): Unable to open given url,
https://isolateserver.appspot.com/content-gs/retrieve/default-gzip/a8a26ac05b...,
after 30 attempts.
Exception: 404 Client Error: Not Found

I'm thinking we need to revert this, but I'm going to double check with kbr@
first to make sure there's not a simple fix or other culprit.

Powered by Google App Engine
This is Rietveld 408576698