Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3438)

Unified Diff: scripts/slave/recipes/gpu/build_and_test.expected/mac_release_tryserver.json

Issue 137993010: Added support for properly building and running isolates in recipes. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Added missed files. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/gpu/build_and_test.expected/mac_release_tryserver.json
diff --git a/scripts/slave/recipes/gpu/build_and_test.expected/mac_release_tryserver.json b/scripts/slave/recipes/gpu/build_and_test.expected/mac_release_tryserver.json
index d2e9e7356b6a5a663ec98871845b8dcb8d186654..1348e09db92785aa1e982da4ef3a848eb7b85e17 100644
--- a/scripts/slave/recipes/gpu/build_and_test.expected/mac_release_tryserver.json
+++ b/scripts/slave/recipes/gpu/build_and_test.expected/mac_release_tryserver.json
@@ -99,7 +99,7 @@
"runhooks"
],
"env": {
- "GYP_DEFINES": "clang=1 component=static_library disable_glibcxx_debug=1 internal_gles2_conform_tests=1 target_arch=ia32",
+ "GYP_DEFINES": "clang=1 component=static_library disable_glibcxx_debug=1 internal_gles2_conform_tests=1 target_arch=ia32 test_isolation_mode=hashtable test_isolation_outdir=https://isolateserver.appspot.com",
"GYP_GENERATORS": "ninja"
},
"name": "gclient runhooks"
@@ -199,9 +199,9 @@
"{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"branch\": \"\", \"build_config\": \"Release\", \"buildername\": \"TestBuilder\", \"buildnumber\": 571, \"issue\": 12853011, \"mastername\": \"chromium.testing.master\", \"patchset\": 1, \"project\": \"chrome\", \"recipe\": \"gpu/build_and_test\", \"repository\": \"\", \"requester\": \"commit-bot@chromium.org\", \"revision\": \"HEAD\", \"rietveld\": \"https://codereview.chromium.org\", \"root\": \"src\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}",
"--build-properties",
"{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"branch\": \"\", \"build_config\": \"Release\", \"buildername\": \"TestBuilder\", \"buildnumber\": 571, \"issue\": 12853011, \"mastername\": \"chromium.testing.master\", \"patchset\": 1, \"project\": \"chrome\", \"recipe\": \"gpu/build_and_test\", \"repository\": \"\", \"requester\": \"commit-bot@chromium.org\", \"revision\": \"HEAD\", \"rietveld\": \"https://codereview.chromium.org\", \"root\": \"src\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}",
- "gl_tests"
+ "angle_unittests"
],
- "name": "gl_tests"
+ "name": "angle_unittests"
},
{
"always_run": true,
@@ -218,9 +218,14 @@
"{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"branch\": \"\", \"build_config\": \"Release\", \"buildername\": \"TestBuilder\", \"buildnumber\": 571, \"issue\": 12853011, \"mastername\": \"chromium.testing.master\", \"patchset\": 1, \"project\": \"chrome\", \"recipe\": \"gpu/build_and_test\", \"repository\": \"\", \"requester\": \"commit-bot@chromium.org\", \"revision\": \"HEAD\", \"rietveld\": \"https://codereview.chromium.org\", \"root\": \"src\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}",
"--build-properties",
"{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"branch\": \"\", \"build_config\": \"Release\", \"buildername\": \"TestBuilder\", \"buildnumber\": 571, \"issue\": 12853011, \"mastername\": \"chromium.testing.master\", \"patchset\": 1, \"project\": \"chrome\", \"recipe\": \"gpu/build_and_test\", \"repository\": \"\", \"requester\": \"commit-bot@chromium.org\", \"revision\": \"HEAD\", \"rietveld\": \"https://codereview.chromium.org\", \"root\": \"src\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}",
- "angle_unittests"
+ "--run-python-script",
+ "[SLAVE_BUILD]/src/tools/swarming_client/run_isolated.py",
+ "-H",
+ "6e784864abbeeff7499c15f75b904851d633c187",
+ "-I",
+ "https://isolateserver.appspot.com"
],
- "name": "angle_unittests"
+ "name": "gl_tests"
},
{
"allow_subannotations": true,

Powered by Google App Engine
This is Rietveld 408576698