[Android] Reduce test logging verbosity.

[Android] Reduce test logging verbosity to INFO on buildbots.

Also, the output of host commands are now at DEBUG level.

BUG=160320
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193479

[Isaac (away), 2013-04-09 02:33:53]

Do you think the verbose logging is a potential cause of these issues?

[frankf, 2013-04-10 19:04:13]

PTAL. 

@ilevy, this is now just meant to reduce noise in the logs.

[Isaac (away), 2013-04-10 19:12:53]

looks good w/ some nits.

https://codereview.chromium.org/13799010/diff/8001/build/android/pylib/androi...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/13799010/diff/8001/build/android/pylib/androi...
build/android/pylib/android_commands.py:199: logging.info('[device]> %s', cmd)
It'd be great to include device serial number here (or a slice of 6 or 7 digits
of it).

https://codereview.chromium.org/13799010/diff/8001/build/android/pylib/cmd_he...
File build/android/pylib/cmd_helper.py (right):

https://codereview.chromium.org/13799010/diff/8001/build/android/pylib/cmd_he...
build/android/pylib/cmd_helper.py:77: args_repr = ' '.join(args)
maybe use ' '.join(map(pipes.quote, args))

This will let the command by copy / pasteable into bash shells.

https://codereview.chromium.org/13799010/diff/8001/build/android/pylib/cmd_he...
build/android/pylib/cmd_helper.py:83: logging.info(s)
put this and the join behind a guard that checks logging level so you don't
construct strings that will get hidden?

[craigdh, 2013-04-10 20:39:49]

lgtm w/ nit.

https://codereview.chromium.org/13799010/diff/8001/build/android/pylib/androi...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/13799010/diff/8001/build/android/pylib/androi...
build/android/pylib/android_commands.py:199: logging.info('[device]> %s', cmd)
On 2013/04/10 19:12:53, Isaac wrote:
> It'd be great to include device serial number here (or a slice of 6 or 7
digits
> of it).

The logging format was just recently changed to include the last 4 digits of the
serial number most of the time anyway, so it's not really necessary to duplicate
it here.

https://codereview.chromium.org/13799010/diff/8001/build/android/pylib/cmd_he...
File build/android/pylib/cmd_helper.py (right):

https://codereview.chromium.org/13799010/diff/8001/build/android/pylib/cmd_he...
build/android/pylib/cmd_helper.py:83: logging.info(s)
On 2013/04/10 19:12:53, Isaac wrote:
> put this and the join behind a guard that checks logging level so you don't
> construct strings that will get hidden?

I don't think the code complexity tradeoff is worth it. To quote Knuth:
"premature optimization is the root of all evil"

https://codereview.chromium.org/13799010/diff/8001/build/android/pylib/cmd_he...
build/android/pylib/cmd_helper.py:95: logging.debug(stdout[:4096])  # Truncate
output longer than 4k.
maybe append a note that the output was truncated if it's longer than 4k?

[frankf, 2013-04-10 21:29:42]

PTAL.

https://codereview.chromium.org/13799010/diff/8001/build/android/pylib/androi...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/13799010/diff/8001/build/android/pylib/androi...
build/android/pylib/android_commands.py:199: logging.info('[device]> %s', cmd)
I added this anyways in case we do something on one of the devices from main
thread.

On 2013/04/10 20:39:49, craigdh wrote:
> On 2013/04/10 19:12:53, Isaac wrote:
> > It'd be great to include device serial number here (or a slice of 6 or 7
> digits
> > of it).
> 
> The logging format was just recently changed to include the last 4 digits of
the
> serial number most of the time anyway, so it's not really necessary to
duplicate
> it here.

https://codereview.chromium.org/13799010/diff/8001/build/android/pylib/cmd_he...
File build/android/pylib/cmd_helper.py (right):

https://codereview.chromium.org/13799010/diff/8001/build/android/pylib/cmd_he...
build/android/pylib/cmd_helper.py:77: args_repr = ' '.join(args)
On 2013/04/10 19:12:53, Isaac wrote:
> maybe use ' '.join(map(pipes.quote, args))
> 
> This will let the command by copy / pasteable into bash shells.

Done. Although the doc says it's deprecated.

https://codereview.chromium.org/13799010/diff/8001/build/android/pylib/cmd_he...
build/android/pylib/cmd_helper.py:83: logging.info(s)
Agreed.

On 2013/04/10 20:39:49, craigdh wrote:
> On 2013/04/10 19:12:53, Isaac wrote:
> > put this and the join behind a guard that checks logging level so you don't
> > construct strings that will get hidden?
> 
> I don't think the code complexity tradeoff is worth it. To quote Knuth:
> "premature optimization is the root of all evil"

https://codereview.chromium.org/13799010/diff/8001/build/android/pylib/cmd_he...
build/android/pylib/cmd_helper.py:95: logging.debug(stdout[:4096])  # Truncate
output longer than 4k.
On 2013/04/10 20:39:49, craigdh wrote:
> maybe append a note that the output was truncated if it's longer than 4k?

Done.

[craigdh, 2013-04-10 21:44:43]

lgtm.

[Isaac (away), 2013-04-10 21:55:16]

sorry, didn't mean to block on buildbot owners.  LGTM

[frankf, 2013-04-10 22:39:04]

Committed patchset #3 manually as r193479 (presubmit successful).

[dgrogan, 2013-04-11 00:24:35]

Android tests failed on the first run that included this patch:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/31...

Related?

[craigdh, 2013-04-11 00:28:52]

On 2013/04/11 00:24:35, dgrogan wrote:
> Android tests failed on the first run that included this patch:
>
http://build.chromium.org/p/chromium.linux/builders/Android%2520Tests/builds/...
> 
> Related?

No, that's a test failing. This just changes the logging of the test scripts.