[Android] Reduce test logging verbosity.

build/android/pylib/cmd_helper.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """A wrapper for subprocess to make calling shell commands easier."""
 
 import os
 import logging
 import signal
 import subprocess
@@ skipping 49 matching lines @@
   Args:
     args: A string or a sequence of program arguments. The program to execute is
       the string or the first item in the args sequence.
     cwd: If not None, the subprocess's current directory will be changed to
       |cwd| before it's executed.
     shell: Whether to execute args as a shell command.
 
   Returns:
     The tuple (exit code, output).
   """
-  logging.info(str(args) + ' ' + (cwd or ''))
+  if isinstance(args, basestring):
+    args_repr = args
+    if not shell:
+      raise Exception('string args must be run with shell=True')
+  elif shell:
+    raise Exception('array args must be run with shell=False')
+  else:
+    args_repr = ' '.join(args)

[Isaac (away), 2013/04/10 19:12:53]

maybe use ' '.join(map(pipes.quote, args))

This will let the command by copy / pasteable into bash shells.

[frankf, 2013/04/10 21:29:42]

Done. Although the doc says it's deprecated.

+
+  s = '[host]'
+  if cwd:
+    s += ':' + cwd
+  s += '> ' + args_repr
+  logging.info(s)

[Isaac (away), 2013/04/10 19:12:53]

put this and the join behind a guard that checks logging level so you don't
construct strings that will get hidden?

[craigdh, 2013/04/10 20:39:49]

I don't think the code complexity tradeoff is worth it. To quote Knuth:
"premature optimization is the root of all evil"

[frankf, 2013/04/10 21:29:42]

Agreed.

On 2013/04/10 20:39:49, craigdh wrote:

   tmpout = tempfile.TemporaryFile(bufsize=0)
   tmperr = tempfile.TemporaryFile(bufsize=0)
   exit_code = _Call(args, cwd=cwd, stdout=tmpout, stderr=tmperr, shell=shell)
   tmperr.seek(0)
   stderr = tmperr.read()
   tmperr.close()
   if stderr:
     logging.critical(stderr)
   tmpout.seek(0)
   stdout = tmpout.read()
   tmpout.close()
-  logging.info(stdout[:4096])  # Truncate output longer than 4k.
+  logging.debug(stdout[:4096])  # Truncate output longer than 4k.

[craigdh, 2013/04/10 20:39:49]

maybe append a note that the output was truncated if it's longer than 4k?

[frankf, 2013/04/10 21:29:42]

Done.

   return (exit_code, stdout)
 
 
 class OutDirectory(object):
   _out_directory = os.path.join(constants.CHROME_DIR, 'out')
   @staticmethod
   def set(out_directory):
     OutDirectory._out_directory = out_directory
   @staticmethod
   def get():
     return OutDirectory._out_directory