Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1379493003: Revert of [heap] Remove retry space from AllocateRaw. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Remove retry space from AllocateRaw. (patchset #3 id:40001 of https://codereview.chromium.org/1370123002/ ) Reason for revert: Breaks arm64 nosnap simulator (bogus cctest?): https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug%20-%201/builds/2934/steps/Bisect%202786ceec.Retry/logs/IncrementalWriteBarri.. Original issue's description: > [heap] Remove retry space from AllocateRaw. > > BUG= > > Committed: https://crrev.com/2786ceec1eb491494d24d29a59eefbe3b6704be2 > Cr-Commit-Position: refs/heads/master@{#30984} TBR=mstarzinger@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/6529971a7fd481e68cfd736c1927dc1876e4f055 Cr-Commit-Position: refs/heads/master@{#30991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -50 lines) Patch
M src/heap/heap.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 26 chunks +92 lines, -39 lines 0 comments Download
M src/heap/heap-inl.h View 4 chunks +15 lines, -9 lines 0 comments Download
M test/cctest/test-alloc.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +111 lines, -0 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 1 chunk +83 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Created Revert of [heap] Remove retry space from AllocateRaw.
5 years, 2 months ago (2015-09-29 04:39:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379493003/1
5 years, 2 months ago (2015-09-29 04:39:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 04:39:58 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 04:40:15 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6529971a7fd481e68cfd736c1927dc1876e4f055
Cr-Commit-Position: refs/heads/master@{#30991}

Powered by Google App Engine
This is Rietveld 408576698