Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: src/heap/heap-inl.h

Issue 1379493003: Revert of [heap] Remove retry space from AllocateRaw. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/heap.cc ('k') | test/cctest/test-alloc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap-inl.h
diff --git a/src/heap/heap-inl.h b/src/heap/heap-inl.h
index d9031807b3736581ffe6c1fe048b182f45d3005b..6c2e36294a4460462ff470bb8d86a73302871794 100644
--- a/src/heap/heap-inl.h
+++ b/src/heap/heap-inl.h
@@ -127,7 +127,7 @@
// Allocate string.
HeapObject* result = nullptr;
{
- AllocationResult allocation = AllocateRaw(size, OLD_SPACE);
+ AllocationResult allocation = AllocateRaw(size, OLD_SPACE, OLD_SPACE);
if (!allocation.To(&result)) return allocation;
}
@@ -158,7 +158,7 @@
// Allocate string.
HeapObject* result = nullptr;
{
- AllocationResult allocation = AllocateRaw(size, OLD_SPACE);
+ AllocationResult allocation = AllocateRaw(size, OLD_SPACE, OLD_SPACE);
if (!allocation.To(&result)) return allocation;
}
@@ -190,6 +190,7 @@
AllocationResult Heap::AllocateRaw(int size_in_bytes, AllocationSpace space,
+ AllocationSpace retry_space,
AllocationAlignment alignment) {
DCHECK(AllowHandleAllocation::IsAllowed());
DCHECK(AllowHeapAllocation::IsAllowed());
@@ -207,14 +208,19 @@
HeapObject* object = nullptr;
AllocationResult allocation;
if (NEW_SPACE == space) {
- if (large_object) {
+ if (!large_object) {
+ allocation = new_space_.AllocateRaw(size_in_bytes, alignment);
+ if (always_allocate() && allocation.IsRetry() &&
+ retry_space != NEW_SPACE) {
+ space = retry_space;
+ } else {
+ if (allocation.To(&object)) {
+ OnAllocationEvent(object, size_in_bytes);
+ }
+ return allocation;
+ }
+ } else {
space = LO_SPACE;
- } else {
- allocation = new_space_.AllocateRaw(size_in_bytes, alignment);
- if (allocation.To(&object)) {
- OnAllocationEvent(object, size_in_bytes);
- }
- return allocation;
}
}
« no previous file with comments | « src/heap/heap.cc ('k') | test/cctest/test-alloc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698