Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1484)

Issue 1379473005: Determine used fonts based on the correct font code path (Closed)

Created:
5 years, 2 months ago by drott
Modified:
5 years, 2 months ago
Reviewers:
lushnikov, wkorman, eae
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, caseq+blink_chromium.org, chromium-reviews, danakj, devtools-reviews_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pdr+graphicswatchlist_chromium.org, pfeldman+blink_chromium.org, rwlbuis, Stephen Chennney, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Determine used fonts based on the correct font code path InspectorCSSAgent previously always instantiated a SimpleShaper, leading to incorrect results when the run was shaped using complex path. BUG=538180 R=eae,lushnikov Committed: https://crrev.com/30fdec9333e9baef6be4826f52bf7ab0f7ba72d7 Cr-Commit-Position: refs/heads/master@{#352311}

Patch Set 1 #

Total comments: 1

Patch Set 2 : case fixed #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/Font.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
drott
5 years, 2 months ago (2015-10-01 15:51:34 UTC) #1
eae
LGTM
5 years, 2 months ago (2015-10-01 16:02:50 UTC) #2
lushnikov
lgtm
5 years, 2 months ago (2015-10-01 17:41:25 UTC) #3
wkorman
https://codereview.chromium.org/1379473005/diff/1/third_party/WebKit/Source/platform/fonts/Font.h File third_party/WebKit/Source/platform/fonts/Font.h (right): https://codereview.chromium.org/1379473005/diff/1/third_party/WebKit/Source/platform/fonts/Font.h#newcode166 third_party/WebKit/Source/platform/fonts/Font.h:166: // For accessing buildGlyphbuffer and retrieving fonts used in ...
5 years, 2 months ago (2015-10-01 17:53:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379473005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379473005/20001
5 years, 2 months ago (2015-10-02 06:56:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/76937)
5 years, 2 months ago (2015-10-02 09:34:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379473005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379473005/20001
5 years, 2 months ago (2015-10-05 08:33:40 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/106001) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 2 months ago (2015-10-05 08:34:52 UTC) #14
drott
rebased
5 years, 2 months ago (2015-10-05 08:39:09 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379473005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379473005/40001
5 years, 2 months ago (2015-10-05 08:39:40 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-05 10:09:31 UTC) #19
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 10:10:34 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/30fdec9333e9baef6be4826f52bf7ab0f7ba72d7
Cr-Commit-Position: refs/heads/master@{#352311}

Powered by Google App Engine
This is Rietveld 408576698