Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 137943002: Update more core classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
Reviewers:
esprehn, eseidel
CC:
blink-reviews, shans, eae+blinkwatch, yurys+blink_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, loislo+blink_chromium.org, aandrey+blink_chromium.org, dino_apple.com, blink-layers+watch_chromium.org, caseq+blink_chromium.org, Steve Block, alancutter (OOO until 2018), pfeldman+blink_chromium.org, Timothy Loh, dstockwell, dglazkov+blink, Rik, gavinp+loader_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, bemjb+rendering_chromium.org, Eric Willigers, philipj_slow, rjwright, zoltan1, sof, lushnikov+blink_chromium.org, kinuko, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, Nate Chapin, chromiumbugtracker_adobe.com, feature-media-reviews_chromium.org, alph+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, Mike Lawther (Google), Inactive
Visibility:
Public.

Description

Update more core classes to use OVERRIDE / FINAL when needed Update more core classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. These were found using the chromium style clang plugin. R=eseidel, esprehn BUG=333316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165072

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -226 lines) Patch
M Source/core/animation/KeyframeEffectModel.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/css/CSSBasicShapes.h View 14 chunks +39 lines, -39 lines 0 comments Download
M Source/core/css/CSSStyleSheet.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/StringCallback.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/EditingStyle.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/fetch/DocumentResource.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/StyleSheetResourceClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/FileReaderLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/DOMWindow.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/animation/CSSPropertyAnimation.cpp View 27 chunks +41 lines, -41 lines 0 comments Download
M Source/core/html/HTMLInputElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMarqueeElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMeterElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/TextControlInnerElements.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorAgent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 4 chunks +27 lines, -27 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorHeapProfilerAgent.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.h View 1 chunk +11 lines, -11 lines 0 comments Download
M Source/core/loader/NavigationScheduler.cpp View 9 chunks +12 lines, -12 lines 0 comments Download
M Source/core/loader/SinkDocument.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/appcache/ApplicationCache.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/AutoTableLayout.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/CompositedLayerMapping.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/InlineFlowBox.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/InlineTextBox.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderFlexibleBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderFlowThread.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderFullScreen.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderInline.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLayerCompositor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerFilterInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderListMarker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMedia.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMultiColumnFlowThread.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderReplaced.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderRubyRun.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTable.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableCell.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableRow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderText.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumDefault.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RootInlineBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/speech/SpeechInputEvent.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 11 months ago (2014-01-14 07:18:27 UTC) #1
esprehn
Rslgtm To unsubscribe from this group and stop receiving emails from it, send an email ...
6 years, 11 months ago (2014-01-14 07:35:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/137943002/1
6 years, 11 months ago (2014-01-14 13:09:02 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 15:52:43 UTC) #4
Message was sent while issue was closed. 
Change committed as 165072

Powered by Google App Engine
This is Rietveld 408576698