Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Unified Diff: Source/core/inspector/InspectorHeapProfilerAgent.cpp

Issue 137943002: Update more core classes to use OVERRIDE / FINAL when needed (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorDebuggerAgent.h ('k') | Source/core/inspector/InspectorStyleSheet.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorHeapProfilerAgent.cpp
diff --git a/Source/core/inspector/InspectorHeapProfilerAgent.cpp b/Source/core/inspector/InspectorHeapProfilerAgent.cpp
index c496fa3e237af5350585edf7ae8b1dc4e894adee..acacd587819b4195a5d228b8bb2c030d2bb01f97 100644
--- a/Source/core/inspector/InspectorHeapProfilerAgent.cpp
+++ b/Source/core/inspector/InspectorHeapProfilerAgent.cpp
@@ -223,12 +223,12 @@ void InspectorHeapProfilerAgent::disable(ErrorString* error)
void InspectorHeapProfilerAgent::getHeapSnapshot(ErrorString* errorString, int rawUid)
{
- class OutputStream : public ScriptHeapSnapshot::OutputStream {
+ class OutputStream FINAL : public ScriptHeapSnapshot::OutputStream {
public:
OutputStream(InspectorFrontend::HeapProfiler* frontend, unsigned uid)
: m_frontend(frontend), m_uid(uid) { }
- void Write(const String& chunk) { m_frontend->addHeapSnapshotChunk(m_uid, chunk); }
- void Close() { }
+ virtual void Write(const String& chunk) OVERRIDE { m_frontend->addHeapSnapshotChunk(m_uid, chunk); }
+ virtual void Close() OVERRIDE { }
private:
InspectorFrontend::HeapProfiler* m_frontend;
int m_uid;
@@ -256,21 +256,21 @@ void InspectorHeapProfilerAgent::removeProfile(ErrorString*, int rawUid)
void InspectorHeapProfilerAgent::takeHeapSnapshot(ErrorString*, const bool* reportProgress)
{
- class HeapSnapshotProgress: public ScriptProfiler::HeapSnapshotProgress {
+ class HeapSnapshotProgress FINAL : public ScriptProfiler::HeapSnapshotProgress {
public:
explicit HeapSnapshotProgress(InspectorFrontend::HeapProfiler* frontend)
: m_frontend(frontend) { }
- void Start(int totalWork)
+ virtual void Start(int totalWork) OVERRIDE
{
m_totalWork = totalWork;
}
- void Worked(int workDone)
+ virtual void Worked(int workDone) OVERRIDE
{
if (m_frontend)
m_frontend->reportHeapSnapshotProgress(workDone, m_totalWork);
}
- void Done() { }
- bool isCanceled() { return false; }
+ virtual void Done() OVERRIDE { }
+ virtual bool isCanceled() OVERRIDE { return false; }
private:
InspectorFrontend::HeapProfiler* m_frontend;
int m_totalWork;
« no previous file with comments | « Source/core/inspector/InspectorDebuggerAgent.h ('k') | Source/core/inspector/InspectorStyleSheet.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698