[Smart Lock, UI] First run expience for Auto sign-in prompt.

[Smart Lock, UI] First run expience for Auto sign-in prompt.

BUG=532876
Committed: https://crrev.com/e6df3095c2ce24944ce3f6efa4e6e3d7c01ccad7
Cr-Commit-Position: refs/heads/master@{#357784}

[melandory, 2015-10-30 17:24:37]

Description was changed from

==========
[Smart Lock, UI] First run expience for Auto sign-in prompt.

BUG=
==========

to

==========
[Smart Lock, UI] First run expience for Auto sign-in prompt.

BUG=532876
==========

[melandory, 2015-11-03 10:54:53]

Patchset #1 (id:1) has been deleted

[melandory, 2015-11-03 10:55:05]

Patchset #1 (id:20001) has been deleted

[melandory, 2015-11-03 13:06:35]

Patchset #1 (id:40001) has been deleted

[melandory, 2015-11-03 14:25:26]

melandory@chromium.org changed reviewers:
+ vabr@chromium.org

[melandory, 2015-11-03 14:25:26]

Hi Vaclav,

please review changes in:
 chrome/browser/password_manager/auto_signin_first_run_infobar_delegate.h
chrome/browser/password_manager/auto_signin_first_run_infobar_delegate.cc
chrome/browser/password_manager/auto_signin_infobar_delegate_unittest.cc
chrome/browser/password_manager/chrome_password_manager_client.cc

chrome/browser/ui/passwords/manage_passwords_view_utils.h
chrome/browser/ui/passwords/manage_passwords_view_utils.cc

[vabr (Chromium), 2015-11-03 15:28:57]

Changes in
chrome/browser/password_manager/auto_signin_first_run_infobar_delegate.h
chrome/browser/password_manager/auto_signin_first_run_infobar_delegate.cc
chrome/browser/password_manager/auto_signin_infobar_delegate_unittest.cc
chrome/browser/password_manager/chrome_password_manager_client.cc

chrome/browser/ui/passwords/manage_passwords_view_utils.h
chrome/browser/ui/passwords/manage_passwords_view_utils.cc

and the *.gypi files LGTM with some nits.

Cheers,
Vaclav

https://codereview.chromium.org/1379153003/diff/100001/chrome/browser/passwor...
File chrome/browser/password_manager/auto_signin_first_run_infobar_delegate.h
(right):

https://codereview.chromium.org/1379153003/diff/100001/chrome/browser/passwor...
chrome/browser/password_manager/auto_signin_first_run_infobar_delegate.h:8:
#include "base/basictypes.h"
Did you mean to #include just "base/macros.h"? There are no basic types used
below.

https://codereview.chromium.org/1379153003/diff/100001/chrome/browser/passwor...
chrome/browser/password_manager/auto_signin_first_run_infobar_delegate.h:10:
#include
"components/password_manager/core/browser/password_manager_metrics_util.h"
This does not look used.

https://codereview.chromium.org/1379153003/diff/100001/chrome/browser/passwor...
File chrome/browser/password_manager/auto_signin_infobar_delegate_unittest.cc
(right):

https://codereview.chromium.org/1379153003/diff/100001/chrome/browser/passwor...
chrome/browser/password_manager/auto_signin_infobar_delegate_unittest.cc:56:
void AutoSigninFirstRunInfobarDelegateTest::SetUp() {
You don't have to define your own SetUp and TearDown if you only call the
super-class' ones.

[melandory, 2015-11-03 16:32:35]

melandory@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[melandory, 2015-11-03 16:32:36]

dfalcantara@chromium.org: Please review changes in 

chrome/android/java/src/org/chromium/chrome/browser/infobar/AutoSigninFirstRunInfobar.java
chrome/browser/android/chrome_jni_registrar.cc
chrome/browser/ui/android/infobars/auto_signin_first_run_infobar.h
chrome/browser/ui/android/infobars/auto_signin_first_run_infobar.cc

https://codereview.chromium.org/1379153003/diff/100001/chrome/browser/passwor...
File chrome/browser/password_manager/auto_signin_first_run_infobar_delegate.h
(right):

https://codereview.chromium.org/1379153003/diff/100001/chrome/browser/passwor...
chrome/browser/password_manager/auto_signin_first_run_infobar_delegate.h:8:
#include "base/basictypes.h"
On 2015/11/03 15:28:57, vabr (Chromium) wrote:
> Did you mean to #include just "base/macros.h"? There are no basic types used
> below.

Done.

https://codereview.chromium.org/1379153003/diff/100001/chrome/browser/passwor...
chrome/browser/password_manager/auto_signin_first_run_infobar_delegate.h:10:
#include
"components/password_manager/core/browser/password_manager_metrics_util.h"
On 2015/11/03 15:28:57, vabr (Chromium) wrote:
> This does not look used.

Done.

https://codereview.chromium.org/1379153003/diff/100001/chrome/browser/passwor...
File chrome/browser/password_manager/auto_signin_infobar_delegate_unittest.cc
(right):

https://codereview.chromium.org/1379153003/diff/100001/chrome/browser/passwor...
chrome/browser/password_manager/auto_signin_infobar_delegate_unittest.cc:56:
void AutoSigninFirstRunInfobarDelegateTest::SetUp() {
On 2015/11/03 15:28:57, vabr (Chromium) wrote:
> You don't have to define your own SetUp and TearDown if you only call the
> super-class' ones.

Done.

[gone, 2015-11-03 18:39:00]

lgtm % nits

https://codereview.chromium.org/1379153003/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/AutoSigninFirstRunInfobar.java
(right):

https://codereview.chromium.org/1379153003/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/infobar/AutoSigninFirstRunInfobar.java:18:
* The Auto Sign-in first run experience infobar is shown instead of usual Auto
sign-in snackbar
nit: Standardize on a capitalization:
Auto Sign-in
Auto sign-in
auto sign-in

https://codereview.chromium.org/1379153003/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/infobar/AutoSigninFirstRunInfobar.java:23:
String mExplanation;
why are these package private?

https://codereview.chromium.org/1379153003/diff/140001/chrome/browser/passwor...
File chrome/browser/password_manager/auto_signin_first_run_infobar_delegate.h
(right):

https://codereview.chromium.org/1379153003/diff/140001/chrome/browser/passwor...
chrome/browser/password_manager/auto_signin_first_run_infobar_delegate.h:14: 
nit: Add class comment

https://codereview.chromium.org/1379153003/diff/140001/chrome/browser/ui/andr...
File chrome/browser/ui/android/infobars/auto_signin_first_run_infobar.h (right):

https://codereview.chromium.org/1379153003/diff/140001/chrome/browser/ui/andr...
chrome/browser/ui/android/infobars/auto_signin_first_run_infobar.h:14: class
AutoSigninFirstRunInfobar : public ConfirmInfoBar {
Change to AutoSigninFirstRunInfoBar; for some reason the B is capitalized for
InfoBars.

https://codereview.chromium.org/1379153003/diff/140001/chrome/browser/ui/andr...
File chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc
(right):

https://codereview.chromium.org/1379153003/diff/140001/chrome/browser/ui/andr...
chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc:20:
LOG(ERROR) << "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAa";
Are these LOG(ERROR)s intentionally being submitted?

[melandory, 2015-11-03 21:43:28]

https://codereview.chromium.org/1379153003/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/AutoSigninFirstRunInfobar.java
(right):

https://codereview.chromium.org/1379153003/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/infobar/AutoSigninFirstRunInfobar.java:18:
* The Auto Sign-in first run experience infobar is shown instead of usual Auto
sign-in snackbar
On 2015/11/03 18:38:59, dfalcantara wrote:
> nit: Standardize on a capitalization:
> Auto Sign-in
> Auto sign-in
> auto sign-in

Done.

https://codereview.chromium.org/1379153003/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/infobar/AutoSigninFirstRunInfobar.java:23:
String mExplanation;
On 2015/11/03 18:38:59, dfalcantara wrote:
> why are these package private?

Done.

https://codereview.chromium.org/1379153003/diff/140001/chrome/browser/passwor...
File chrome/browser/password_manager/auto_signin_first_run_infobar_delegate.h
(right):

https://codereview.chromium.org/1379153003/diff/140001/chrome/browser/passwor...
chrome/browser/password_manager/auto_signin_first_run_infobar_delegate.h:14: 
On 2015/11/03 18:39:00, dfalcantara wrote:
> nit: Add class comment

Done.

https://codereview.chromium.org/1379153003/diff/140001/chrome/browser/ui/andr...
File chrome/browser/ui/android/infobars/auto_signin_first_run_infobar.h (right):

https://codereview.chromium.org/1379153003/diff/140001/chrome/browser/ui/andr...
chrome/browser/ui/android/infobars/auto_signin_first_run_infobar.h:14: class
AutoSigninFirstRunInfobar : public ConfirmInfoBar {
On 2015/11/03 18:39:00, dfalcantara wrote:
> Change to AutoSigninFirstRunInfoBar; for some reason the B is capitalized for
> InfoBars.

Done.

https://codereview.chromium.org/1379153003/diff/140001/chrome/browser/ui/andr...
File chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc
(right):

https://codereview.chromium.org/1379153003/diff/140001/chrome/browser/ui/andr...
chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc:20:
LOG(ERROR) << "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAa";
On 2015/11/03 18:39:00, dfalcantara wrote:
> Are these LOG(ERROR)s intentionally being submitted?

Sorry, removed.

[melandory, 2015-11-03 21:45:52]

melandory@chromium.org changed reviewers:
+ tedchoc@chromium.org

[melandory, 2015-11-03 21:45:53]

tedchoc@chromium.org: Please review changes in 

chrome/browser/ui/android/snackbars/

[Ted C, 2015-11-04 00:36:48]

On 2015/11/03 21:45:53, melandory wrote:
> mailto:tedchoc@chromium.org: Please review changes in 
> 
> chrome/browser/ui/android/snackbars/

chrome/browser/ui/android/snackbars/ - lgtm

[melandory, 2015-11-04 08:21:45]

The CQ bit was checked by melandory@chromium.org

[melandory, 2015-11-04 08:21:46]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org,
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1379153003/#ps180001
(title: "AutoSigninFirstRunInfoBar.java")

[commit-bot: I haz the power, 2015-11-04 08:22:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1379153003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1379153003/180001

[commit-bot: I haz the power, 2015-11-04 08:48:45]

Committed patchset #7 (id:180001)

[commit-bot: I haz the power, 2015-11-04 08:49:36]

Patchset 7 (id:??) landed as
https://crrev.com/e6df3095c2ce24944ce3f6efa4e6e3d7c01ccad7
Cr-Commit-Position: refs/heads/master@{#357784}