chrome/browser/password_manager/chrome_password_manager_client.cc - Issue 1379153003: [Smart Lock, UI] First run expience for Auto sign-in prompt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 1379153003: [Smart Lock, UI] First run expience for Auto sign-in prompt. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: AutoSigninFirstRunInfoBar.java Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/auto_signin_infobar_delegate_unittest.cc ('k') | chrome/browser/ui/android/infobars/auto_signin_first_run_infobar.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/chrome_password_manager_client.cc

diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc

index 03e8e0985d001d1eede734d962bd4fa17c82f6cf..98505c4ce2f06d4c1f78f9f1985684ab7af9c96a 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client.cc

+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc

@@ -56,7 +56,7 @@

#if defined(OS_ANDROID)

#include "chrome/browser/android/tab_android.h"

#include "chrome/browser/password_manager/generated_password_saved_infobar_delegate_android.h"

-#include "chrome/browser/ui/android/snackbars/auto_signin_snackbar_controller.h"

+#include "chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.h"

#endif

using password_manager::ContentPasswordManagerDriverFactory;

@@ -262,8 +262,7 @@ void ChromePasswordManagerClient::NotifyUserAutoSignin(

ScopedVector<autofill::PasswordForm> local_forms) {

DCHECK(!local_forms.empty());

#if defined(OS_ANDROID)

- TabAndroid *tab = TabAndroid::FromWebContents(web_contents());

- ShowAutoSigninSnackbar(tab, local_forms[0]->username_value);

+ ShowAutoSigninPrompt(web_contents(), local_forms[0]->username_value);

#else

ManagePasswordsUIController::FromWebContents(web_contents())->

OnAutoSignin(local_forms.Pass());