Issue 1379093003: Merge to XFA: Turn a couple functions that always return true to return void.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1379093003: Merge to XFA: Turn a couple functions that always return true to return void. (Closed)

Created:
5 years, 2 months ago by Lei Zhang

Modified:
5 years, 2 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Turn a couple functions that always return true to return void. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1386463003 . (cherry picked from commit dcfa0ba2928072c962fe8835d1a2ccd309eafbbd) Committed: https://pdfium.googlesource.com/pdfium/+/ea5c4d3929928b318b339231804580d93a6e5f21

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -27 lines)			Patch
M	core/include/fxge/fx_font.h	View	1 chunk	+7 lines, -8 lines	0 comments	Download
M	core/src/fpdftext/fpdf_text_int.cpp	View	2 chunks	+6 lines, -7 lines	0 comments	Download
M	core/src/fpdftext/text_int.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/src/fxge/ge/fx_ge_font.cpp	View	2 chunks	+7 lines, -8 lines	0 comments	Download
M	xfa/src/fgas/src/font/fx_gefont.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Lei Zhang

5 years, 2 months ago (2015-10-02 19:28:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
ea5c4d3929928b318b339231804580d93a6e5f21 (presubmit successful).