Merge to XFA: Turn a couple functions that always return true to return void.

core/src/fpdftext/fpdf_text_int.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include <ctype.h>
 #include <algorithm>
 
 #include "../../../third_party/base/nonstd_unique_ptr.h"
@@ skipping 2596 matching lines @@
           FX_WCHAR ch = strBeCheck.GetAt(strBeCheck.GetLength() - 1);
           if (ch == L')' || ch == L',' || ch == L'>' || ch == L'.') {
             strBeCheck = strBeCheck.Mid(0, strBeCheck.GetLength() - 1);
             nCount--;
           } else {
             break;
           }
         }
         if (nCount > 5 &&
             (CheckWebLink(strBeCheck) || CheckMailLink(strBeCheck))) {
-          if (!AppendToLinkList(start, nCount, strBeCheck)) {
-            break;
-          }
+          AppendToLinkList(start, nCount, strBeCheck);
         }
       }
       start = ++pos;
     } else {
       pos++;
     }
   }
 }
 FX_BOOL CPDF_LinkExtract::CheckWebLink(CFX_WideString& strBeCheck) {
   CFX_WideString str = strBeCheck;
@@ skipping 93 matching lines @@
       continue;
     } else {
       return FALSE;
     }
   }
   if (str.Find(L"mailto:") == -1) {
     str = L"mailto:" + str;
   }
   return TRUE;
 }
-FX_BOOL CPDF_LinkExtract::AppendToLinkList(int start,
-                                           int count,
-                                           const CFX_WideString& strUrl) {
+
+void CPDF_LinkExtract::AppendToLinkList(int start,
+                                        int count,
+                                        const CFX_WideString& strUrl) {
   CPDF_LinkExt* linkInfo = new CPDF_LinkExt;
   linkInfo->m_strUrl = strUrl;
   linkInfo->m_Start = start;
   linkInfo->m_Count = count;
   m_LinkList.Add(linkInfo);
-  return TRUE;
 }
+
 CFX_WideString CPDF_LinkExtract::GetURL(int index) const {
   if (!m_IsParserd || index < 0 || index >= m_LinkList.GetSize()) {
     return L"";
   }
   CPDF_LinkExt* link = NULL;
   link = m_LinkList.GetAt(index);
   if (!link) {
     return L"";
   }
   return link->m_strUrl;
@@ skipping 16 matching lines @@
   if (!m_IsParserd || index < 0 || index >= m_LinkList.GetSize()) {
     return;
   }
   CPDF_LinkExt* link = NULL;
   link = m_LinkList.GetAt(index);
   if (!link) {
     return;
   }
   m_pTextPage->GetRectArray(link->m_Start, link->m_Count, rects);
 }