Issue 137893017: Rebuild Views Textfield context menu runner on each showing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137893017: Rebuild Views Textfield context menu runner on each showing. (Closed)

Created:
6 years, 11 months ago by msw

Modified:
6 years, 11 months ago

Reviewers:
sky

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, penghuang+watch_chromium.org, nona+watch_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rebuild Views Textfield context menu runner on each showing. Without rebuilding, stale command states are used. That may leave menu items incorrectly enabled/disabled. Fixes a regression from http://crrev.com/244436 BUG=334604 TEST=Bug doesn't repro; omnibox and textfield context menu items are enabled or disabled as expected on each menu invocation. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245461

Patch Set 1 #

Patch Set 2 : Just recreate the menu runner on each showing. #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	ui/views/controls/textfield/textfield.cc	View	1	2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/137893017/20001

6 years, 11 months ago (2014-01-17 00:44:19 UTC) #3

Message was sent while issue was closed.

Change committed as 245461

Expand Messages | Collapse Messages