Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: ui/views/controls/textfield/textfield.cc

Issue 137893017: Rebuild Views Textfield context menu runner on each showing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Just recreate the menu runner on each showing. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/textfield/textfield.cc
diff --git a/ui/views/controls/textfield/textfield.cc b/ui/views/controls/textfield/textfield.cc
index 8d31a8929b015e40c16e1af896f78cc0244492cb..be70db2f4492d6266c88d0a97d2022126f752599 100644
--- a/ui/views/controls/textfield/textfield.cc
+++ b/ui/views/controls/textfield/textfield.cc
@@ -22,7 +22,6 @@
#include "ui/views/background.h"
#include "ui/views/controls/focusable_border.h"
#include "ui/views/controls/menu/menu_item_view.h"
-#include "ui/views/controls/menu/menu_model_adapter.h"
#include "ui/views/controls/menu/menu_runner.h"
#include "ui/views/controls/native/native_view_host.h"
#include "ui/views/controls/textfield/textfield_controller.h"
@@ -1497,8 +1496,8 @@ void Textfield::UpdateContextMenu() {
IDS_APP_SELECT_ALL);
if (controller_)
controller_->UpdateContextMenu(context_menu_contents_.get());
- context_menu_runner_.reset(new MenuRunner(context_menu_contents_.get()));
}
+ context_menu_runner_.reset(new MenuRunner(context_menu_contents_.get()));
}
void Textfield::TrackMouseClicks(const ui::MouseEvent& event) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698