Issue 137893010: Revert 245010 "Inject GPUDataManager support into ash to abstrac..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137893010: Revert 245010 "Inject GPUDataManager support into ash to abstrac..." (Closed)

Created:
6 years, 11 months ago by Ben Goodger (Google)

Modified:
6 years, 11 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 245010 "Inject GPUDataManager support into ash to abstrac..." > Inject GPUDataManager support into ash to abstract a content dependency. > > http://crbug.com/332504 > > R=oshima@chromium.org > > Review URL: https://codereview.chromium.org/138223004 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245018

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -215 lines)			Patch
M	trunk/src/ash/DEPS	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	trunk/src/ash/accelerators/accelerator_controller.cc	View	3 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/ash/ash.gyp	View	2 chunks	+1 line, -6 lines	0 comments	Download
A +	trunk/src/ash/ash_with_content_export.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	trunk/src/ash/content_support/DEPS	View	1 chunk	+0 lines, -5 lines	0 comments	Download
D	trunk/src/ash/content_support/ash_with_content_export.h	View	1 chunk	+0 lines, -32 lines	0 comments	Download
D	trunk/src/ash/content_support/gpu_support_impl.h	View	1 chunk	+0 lines, -29 lines	0 comments	Download
D	trunk/src/ash/content_support/gpu_support_impl.cc	View	1 chunk	+0 lines, -32 lines	0 comments	Download
D	trunk/src/ash/content_support/inject.h	View	1 chunk	+0 lines, -16 lines	0 comments	Download
D	trunk/src/ash/content_support/inject.cc	View	1 chunk	+0 lines, -17 lines	0 comments	Download
D	trunk/src/ash/gpu_support.h	View	1 chunk	+0 lines, -34 lines	0 comments	Download
M	trunk/src/ash/keyboard_overlay/keyboard_overlay_delegate.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ash/keyboard_overlay/keyboard_overlay_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ash/screensaver/screensaver_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ash/shell.h	View	3 chunks	+0 lines, -7 lines	0 comments	Download
M	trunk/src/ash/shell.cc	View	6 chunks	+8 lines, -25 lines	0 comments	Download
M	trunk/src/ash/shell/content_client/shell_browser_main_parts.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	trunk/src/ash/system/monitor/tray_monitor.cc	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/ash/ash_init.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

6 years, 11 months ago (2014-01-15 23:19:28 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r245018 (tree was closed).

Expand Messages | Collapse Messages