Inject GPUDataManager support into ash to abstract a content dependency.

Inject GPUDataManager support into ash to abstract a content dependency.

http://crbug.com/332504

R=oshima@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245010

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245161

[Ben Goodger (Google), 2014-01-15 20:08:21]

This is the pattern I'll use for code used from ash types that can't be moved to
ash_with_content.

[oshima, 2014-01-15 20:20:51]

lgtm with an optional nit.

https://codereview.chromium.org/138223004/diff/200001/ash/shell.h
File ash/shell.h (right):

https://codereview.chromium.org/138223004/diff/200001/ash/shell.h#newcode542
ash/shell.h:542: void SetGPUSupport(GPUSupport* gpu_support);
nit: how about using scoped_ptr<> and Pass() ?

[Ben Goodger (Google), 2014-01-15 20:26:59]

On 2014/01/15 20:20:51, oshima wrote:
> lgtm with an optional nit.
> 
> https://codereview.chromium.org/138223004/diff/200001/ash/shell.h
> File ash/shell.h (right):
> 
> https://codereview.chromium.org/138223004/diff/200001/ash/shell.h#newcode542
> ash/shell.h:542: void SetGPUSupport(GPUSupport* gpu_support);
> nit: how about using scoped_ptr<> and Pass() ?

good idea.. done.

[Ben Goodger (Google), 2014-01-15 22:59:42]

Committed patchset #9 manually as r245010 (presubmit successful).

[commit-bot: I haz the power, 2014-01-15 23:52:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ben@chromium.org/138223004/380001

[commit-bot: I haz the power, 2014-01-16 06:09:52]

Change committed as 245161