Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 137883008: Use PropertyAccessType for keyed accesses rather than "bool is_store" (Closed)

Created:
6 years, 10 months ago by Toon Verwaest
Modified:
6 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Use PropertyAccessType for keyed accesses rather than "bool is_store" BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19221

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -79 lines) Patch
M src/code-stubs-hydrogen.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/hydrogen.h View 7 chunks +7 lines, -9 lines 0 comments Download
M src/hydrogen.cc View 31 chunks +54 lines, -54 lines 0 comments Download
M src/hydrogen-instructions.h View 4 chunks +6 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 10 months ago (2014-02-10 11:38:10 UTC) #1
Igor Sheludko
lgtm
6 years, 10 months ago (2014-02-10 11:42:55 UTC) #2
Toon Verwaest
6 years, 10 months ago (2014-02-10 11:43:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19221 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698