Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: src/code-stubs-hydrogen.cc

Issue 137883008: Use PropertyAccessType for keyed accesses rather than "bool is_store" (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 534 matching lines...) Expand 10 before | Expand all | Expand 10 after
545 Handle<Code> CreateAllocationSiteStub::GenerateCode(Isolate* isolate) { 545 Handle<Code> CreateAllocationSiteStub::GenerateCode(Isolate* isolate) {
546 return DoGenerateCode(isolate, this); 546 return DoGenerateCode(isolate, this);
547 } 547 }
548 548
549 549
550 template <> 550 template <>
551 HValue* CodeStubGraphBuilder<KeyedLoadFastElementStub>::BuildCodeStub() { 551 HValue* CodeStubGraphBuilder<KeyedLoadFastElementStub>::BuildCodeStub() {
552 HInstruction* load = BuildUncheckedMonomorphicElementAccess( 552 HInstruction* load = BuildUncheckedMonomorphicElementAccess(
553 GetParameter(0), GetParameter(1), NULL, 553 GetParameter(0), GetParameter(1), NULL,
554 casted_stub()->is_js_array(), casted_stub()->elements_kind(), 554 casted_stub()->is_js_array(), casted_stub()->elements_kind(),
555 false, NEVER_RETURN_HOLE, STANDARD_STORE); 555 LOAD, NEVER_RETURN_HOLE, STANDARD_STORE);
556 return load; 556 return load;
557 } 557 }
558 558
559 559
560 Handle<Code> KeyedLoadFastElementStub::GenerateCode(Isolate* isolate) { 560 Handle<Code> KeyedLoadFastElementStub::GenerateCode(Isolate* isolate) {
561 return DoGenerateCode(isolate, this); 561 return DoGenerateCode(isolate, this);
562 } 562 }
563 563
564 564
565 template<> 565 template<>
(...skipping 26 matching lines...) Expand all
592 Handle<Code> KeyedLoadFieldStub::GenerateCode(Isolate* isolate) { 592 Handle<Code> KeyedLoadFieldStub::GenerateCode(Isolate* isolate) {
593 return DoGenerateCode(isolate, this); 593 return DoGenerateCode(isolate, this);
594 } 594 }
595 595
596 596
597 template <> 597 template <>
598 HValue* CodeStubGraphBuilder<KeyedStoreFastElementStub>::BuildCodeStub() { 598 HValue* CodeStubGraphBuilder<KeyedStoreFastElementStub>::BuildCodeStub() {
599 BuildUncheckedMonomorphicElementAccess( 599 BuildUncheckedMonomorphicElementAccess(
600 GetParameter(0), GetParameter(1), GetParameter(2), 600 GetParameter(0), GetParameter(1), GetParameter(2),
601 casted_stub()->is_js_array(), casted_stub()->elements_kind(), 601 casted_stub()->is_js_array(), casted_stub()->elements_kind(),
602 true, NEVER_RETURN_HOLE, casted_stub()->store_mode()); 602 STORE, NEVER_RETURN_HOLE, casted_stub()->store_mode());
603 603
604 return GetParameter(2); 604 return GetParameter(2);
605 } 605 }
606 606
607 607
608 Handle<Code> KeyedStoreFastElementStub::GenerateCode(Isolate* isolate) { 608 Handle<Code> KeyedStoreFastElementStub::GenerateCode(Isolate* isolate) {
609 return DoGenerateCode(isolate, this); 609 return DoGenerateCode(isolate, this);
610 } 610 }
611 611
612 612
(...skipping 476 matching lines...) Expand 10 before | Expand all | Expand 10 after
1089 info()->MarkAsSavesCallerDoubles(); 1089 info()->MarkAsSavesCallerDoubles();
1090 1090
1091 BuildTransitionElementsKind(object, map, 1091 BuildTransitionElementsKind(object, map,
1092 casted_stub()->from_kind(), 1092 casted_stub()->from_kind(),
1093 casted_stub()->to_kind(), 1093 casted_stub()->to_kind(),
1094 casted_stub()->is_jsarray()); 1094 casted_stub()->is_jsarray());
1095 1095
1096 BuildUncheckedMonomorphicElementAccess(object, key, value, 1096 BuildUncheckedMonomorphicElementAccess(object, key, value,
1097 casted_stub()->is_jsarray(), 1097 casted_stub()->is_jsarray(),
1098 casted_stub()->to_kind(), 1098 casted_stub()->to_kind(),
1099 true, ALLOW_RETURN_HOLE, 1099 STORE, ALLOW_RETURN_HOLE,
1100 casted_stub()->store_mode()); 1100 casted_stub()->store_mode());
1101 } 1101 }
1102 1102
1103 return value; 1103 return value;
1104 } 1104 }
1105 1105
1106 1106
1107 Handle<Code> ElementsTransitionAndStoreStub::GenerateCode(Isolate* isolate) { 1107 Handle<Code> ElementsTransitionAndStoreStub::GenerateCode(Isolate* isolate) {
1108 return DoGenerateCode(isolate, this); 1108 return DoGenerateCode(isolate, this);
1109 } 1109 }
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
1399 return BuildRegExpConstructResult(length, index, input); 1399 return BuildRegExpConstructResult(length, index, input);
1400 } 1400 }
1401 1401
1402 1402
1403 Handle<Code> RegExpConstructResultStub::GenerateCode(Isolate* isolate) { 1403 Handle<Code> RegExpConstructResultStub::GenerateCode(Isolate* isolate) {
1404 return DoGenerateCode(isolate, this); 1404 return DoGenerateCode(isolate, this);
1405 } 1405 }
1406 1406
1407 1407
1408 } } // namespace v8::internal 1408 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698