Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Issue 137863007: Revert of Move most of the [Pass]RefPtr's of CSSPrimitiveValue to our transition types. (Closed)

Created:
6 years, 10 months ago by abarth-chromium
Modified:
6 years, 10 months ago
CC:
blink-reviews, shans, fs, yurys+blink_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, Inactive, loislo+blink_chromium.org, Steve Block, dino_apple.com, rwlbuis, krit, alancutter (OOO until 2018), Timothy Loh, abarth-chromium, dstockwell, dglazkov+blink, pdr., rune+blink, Eric Willigers, rjwright, Mads Ager (chromium), gyuyoung.kim_webkit.org, darktears, Mike Lawther (Google), ed+blinkwatch_opera.com, f(malita), groby+blinkspell_chromium.org, Stephen Chennney, Mikhail
Visibility:
Public.

Description

Revert of Move most of the [Pass]RefPtr's of CSSPrimitiveValue to our transition types. (https://codereview.chromium.org/148523016/) Reason for revert: Does not compile on Android: http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder%20%28dbg%29/builds/24577/steps/compile/logs/stdio /mnt/data/b/build/slave/Android_Builder__dbg_/build/src/third_party/android_tools/ndk//sources/cxx-stl/stlport/stlport/stl/_construct.h:139:3:error: no matching function for call to 'WebCore::CSSGradientColorStop::operator new(unsigned int, WebCore::CSSGradientColorStop*&)' /mnt/data/b/build/slave/Android_Builder__dbg_/build/src/third_party/android_tools/ndk//sources/cxx-stl/stlport/stlport/stl/_construct.h:139:3: note: candidates are: ../../third_party/WebKit/Source/core/css/CSSGradientValue.h:56:5: note: static void* WebCore::CSSGradientColorStop::operator new(size_t, NotNullTag, void*) ../../third_party/WebKit/Source/core/css/CSSGradientValue.h:56:5: note: candidate expects 3 arguments, 2 provided ../../third_party/WebKit/Source/core/css/CSSGradientValue.h:56:5: note: static void* WebCore::CSSGradientColorStop::operator new(size_t) ../../third_party/WebKit/Source/core/css/CSSGradientValue.h:56:5: note: candidate expects 1 argument, 2 provided Original issue's description: > Move most of the [Pass]RefPtr's of CSSPrimitiveValue to our transition types. > > I still need to move the CSSPrimitiveValues referred from the classes > > . Pair > . Counter > . CSSBasicShape and subclasses > . CSSCalcExpressionNode and subclasses > . RectBase and subclasses > > Instead of using Persistents I plan on moving the objects to the oilpan heap. > I also added a TraceTrait for RefPtr to compile trace method bodies in non-oilpan mode when tracing collections. > Finally I changed RawPtr's release() to zero out the m_ptr to match RefPtr's version. > > R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, jochen@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org > BUG=341815 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167022 TBR=ager@chromium.org,erik.corry@gmail.com,haraken@chromium.org,jochen@chromium.org,tkent@chromium.org,vegorov@chromium.org,zerny@chromium.org,wibling@chromium.org NOTREECHECKS=true NOTRY=true BUG=341815 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167026

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+316 lines, -417 lines) Patch
M Source/core/animation/AnimatableLength.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/AnimatableLength.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/BasicShapeFunctions.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSBorderImageSliceValue.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSBorderImageSliceValue.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 10 chunks +29 lines, -29 lines 0 comments Download
M Source/core/css/CSSCrossfadeValue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSCrossfadeValue.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSFontValue.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/css/CSSFontValue.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/css/CSSGradientValue.h View 7 chunks +29 lines, -38 lines 0 comments Download
M Source/core/css/CSSGradientValue.cpp View 4 chunks +0 lines, -18 lines 0 comments Download
M Source/core/css/CSSImageValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSParserValues.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSPrimitiveValue.h View 2 chunks +15 lines, -38 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSReflectValue.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/CSSReflectValue.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSShadowValue.h View 2 chunks +18 lines, -18 lines 0 comments Download
M Source/core/css/CSSShadowValue.cpp View 2 chunks +6 lines, -12 lines 0 comments Download
M Source/core/css/CSSValuePool.h View 2 chunks +18 lines, -18 lines 0 comments Download
M Source/core/css/CSSValuePool.cpp View 5 chunks +19 lines, -30 lines 0 comments Download
M Source/core/css/RGBColor.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/RGBColor.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/css/Rect.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/SVGCSSComputedStyleDeclaration.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser.h View 8 chunks +14 lines, -14 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 75 chunks +115 lines, -116 lines 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/EditingStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditorCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLHRElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLength.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGLength.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/heap/Handle.h View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/heap/Heap.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/wtf/RawPtr.h View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
Created Revert of Move most of the [Pass]RefPtr's of CSSPrimitiveValue to our transition types.
6 years, 10 months ago (2014-02-12 17:35:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/137863007/1
6 years, 10 months ago (2014-02-12 17:35:29 UTC) #2
commit-bot: I haz the power
6 years, 10 months ago (2014-02-12 17:36:07 UTC) #3
Message was sent while issue was closed.
Change committed as 167026

Powered by Google App Engine
This is Rietveld 408576698