Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 1378623002: chromium_tests: make IsolatedScript use run_isolated directly, not runtest (Closed)

Created:
5 years, 2 months ago by Paweł Hajdan Jr.
Modified:
5 years, 2 months ago
CC:
aiolos (Not reviewing), chromium-reviews, eakuefner, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

chromium_tests: make IsolatedScript use run_isolated directly, not runtest Depends on https://codereview.chromium.org/1374943002 BUG=507796, 533479, 533141 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296942

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
Paweł Hajdan Jr.
5 years, 2 months ago (2015-09-29 15:05:30 UTC) #2
Ken Russell (switch to Gerrit)
LGTM, but I'm not sure telemetry_unittests and telemetry_perf_unittests will work without runtest and its use ...
5 years, 2 months ago (2015-09-29 17:17:14 UTC) #3
nednguyen
On 2015/09/29 17:17:14, Ken Russell wrote: > LGTM, but I'm not sure telemetry_unittests and telemetry_perf_unittests ...
5 years, 2 months ago (2015-09-29 23:23:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378623002/1
5 years, 2 months ago (2015-09-30 07:37:18 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 07:42:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296942

Powered by Google App Engine
This is Rietveld 408576698