Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1374943002: isolate: add run_isolated, deprecate runtest (Closed)

Created:
5 years, 2 months ago by Paweł Hajdan Jr.
Modified:
5 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

isolate: add run_isolated, deprecate runtest More tests are using isolate (e.g. https://codereview.chromium.org/1354223004, https://code.google.com/p/chromium/issues/detail?id=507796) and we're also trying to get rid of runtest.py, or at least not to use it in new code. BUG=507796 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296925

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -0 lines) Patch
M scripts/slave/recipe_modules/isolate/api.py View 1 1 chunk +14 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/isolate/example.py View 1 1 chunk +7 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/isolate/example.expected/basic.json View 1 1 chunk +16 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/isolate/example.expected/discover.json View 1 1 chunk +16 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/isolate/example.expected/extra.json View 1 1 chunk +16 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/isolate/example.expected/missing.json View 1 1 chunk +16 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/isolate/example.expected/none.json View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Paweł Hajdan Jr.
5 years, 2 months ago (2015-09-29 12:18:38 UTC) #2
M-A Ruel
lgtm https://codereview.chromium.org/1374943002/diff/1/scripts/slave/recipe_modules/isolate/api.py File scripts/slave/recipe_modules/isolate/api.py (right): https://codereview.chromium.org/1374943002/diff/1/scripts/slave/recipe_modules/isolate/api.py#newcode224 scripts/slave/recipe_modules/isolate/api.py:224: '--verbose', Remove, unless it's to test out then ...
5 years, 2 months ago (2015-09-29 12:21:39 UTC) #3
Paweł Hajdan Jr.
https://codereview.chromium.org/1374943002/diff/1/scripts/slave/recipe_modules/isolate/api.py File scripts/slave/recipe_modules/isolate/api.py (right): https://codereview.chromium.org/1374943002/diff/1/scripts/slave/recipe_modules/isolate/api.py#newcode224 scripts/slave/recipe_modules/isolate/api.py:224: '--verbose', On 2015/09/29 at 12:21:39, M-A Ruel wrote: > ...
5 years, 2 months ago (2015-09-29 12:25:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374943002/20001
5 years, 2 months ago (2015-09-29 12:26:00 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 12:28:45 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296925

Powered by Google App Engine
This is Rietveld 408576698