Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1378613005: input[type=number] should not accept numbers ending with '.'. (Closed)

Created:
5 years, 2 months ago by tkent
Modified:
5 years, 2 months ago
Reviewers:
keishi, yosin_UTC9
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

input[type=number] should not accept numbers ending with '.'. https://html.spec.whatwg.org/multipage/infrastructure.html#floating-point-numbers > 1. Optionally, a U+002D HYPHEN-MINUS character (-). > 2. One or both of the following, in the given order: > 1. A series of one or more ASCII digits. > 2. Both of the following, in the given order: > 1. A single U+002E FULL STOP character (.). > 2. A series of one or more ASCII digits. > 3. Optionally: > 1. Either a U+0065 LATIN SMALL LETTER E character (e) or a U+0045 LATIN > CAPITAL LETTER E character (E). > 2. Optionally, a U+002D HYPHEN-MINUS character (-) or U+002B PLUS SIGN > character (+). > 3. A series of one or more ASCII digits. If '.' exists, digits must follow it. BUG=529686 Committed: https://crrev.com/4338941612abccd04a9e180894962f6ae488ed7b Cr-Commit-Position: refs/heads/master@{#351522}

Patch Set 1 : #

Messages

Total messages: 8 (3 generated)
tkent
keishi@ or yosin@, please review this.
5 years, 2 months ago (2015-09-30 06:58:32 UTC) #3
keishi
LGTM
5 years, 2 months ago (2015-09-30 06:59:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378613005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378613005/20001
5 years, 2 months ago (2015-09-30 07:44:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 2 months ago (2015-09-30 08:50:26 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 08:51:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4338941612abccd04a9e180894962f6ae488ed7b
Cr-Commit-Position: refs/heads/master@{#351522}

Powered by Google App Engine
This is Rietveld 408576698