third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.cpp - Issue 1378613005: input[type=number] should not accept numbers ending with '.'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.cpp

Issue 1378613005: input[type=number] should not accept numbers ending with '.'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/imported/web-platform-tests/html/semantics/forms/the-input-element/number-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.cpp b/third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.cpp

index bcab21ac3f46e0c2da6f6670a0dfe911f50805aa..eb108dc9568e4d0f03e88f39ee50ac68c049cc97 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.cpp

@@ -121,6 +121,8 @@ double parseToDoubleForNumberType(const String& string, double fallbackValue)

UChar firstCharacter = string[0];

if (firstCharacter != '-' && firstCharacter != '.' && !isASCIIDigit(firstCharacter))

return fallbackValue;

+ if (string.endsWith('.'))

+ return fallbackValue;

bool valid = false;

double value = string.toDouble(&valid);