Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Unified Diff: content/browser/renderer_host/ime_adapter_android.cc

Issue 1378583003: Unstrangle unhandled key event callback for webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/ime_adapter_android.cc
diff --git a/content/browser/renderer_host/ime_adapter_android.cc b/content/browser/renderer_host/ime_adapter_android.cc
index dbad05cf8b619b442eb549a56f6a87af8dce683e..f1ee0a46dd1bff2adcd8dd796a7afdaf33e12f36 100644
--- a/content/browser/renderer_host/ime_adapter_android.cc
+++ b/content/browser/renderer_host/ime_adapter_android.cc
@@ -151,7 +151,7 @@ bool ImeAdapterAndroid::SendKeyEvent(JNIEnv* env, jobject,
// If we are going to follow up with a synthetic Char event, then that's the
// one we expect to test if it's handled or unhandled, so skip handling the
// "real" event in the browser.
- event.skip_in_browser = key_down_text_insertion;
+ event.skip_in_browser = true;
aelias_OOO_until_Jul13 2015/10/02 20:11:51 "true" seems unnecessarily broad. That will suppr
rwhva_->SendKeyEvent(event);
if (key_down_text_insertion) {
// Send a Char event, but without an os_event since we don't want to
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698