Unstrangle unhandled key event callback for webview

content/browser/renderer_host/ime_adapter_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/ime_adapter_android.h"
 
 #include <algorithm>
 #include <android/input.h>
 #include <vector>
 
@@ skipping 133 matching lines @@
                                      int scan_code, bool is_system_key,
                                      int unicode_char) {
   NativeWebKeyboardEvent event = NativeWebKeyboardEventFromKeyEvent(
           env, original_key_event, action, modifiers,
           time_ms, key_code, scan_code, is_system_key, unicode_char);
   bool key_down_text_insertion =
       event.type == blink::WebInputEvent::RawKeyDown && event.text[0];
   // If we are going to follow up with a synthetic Char event, then that's the
   // one we expect to test if it's handled or unhandled, so skip handling the
   // "real" event in the browser.
-  event.skip_in_browser = key_down_text_insertion;
+  event.skip_in_browser = true;

[aelias_OOO_until_Jul13, 2015/10/02 20:11:51]

"true" seems unnecessarily broad.  That will suppress browser handling of all
key events (for example, F1-F10 keys), but the intent of benm's patch was just
to suppress the events which are duplicative with a Char event.  I think we
should only broaden suppression to Up events that also correspond to a Char
event.  So I suggest writing: "event.skip_in_browser = event.text[0];" instead.

   rwhva_->SendKeyEvent(event);
   if (key_down_text_insertion) {
     // Send a Char event, but without an os_event since we don't want to
     // roundtrip back to java such synthetic event.
     NativeWebKeyboardEvent char_event(blink::WebInputEvent::Char, modifiers,
                                       time_ms / 1000.0, key_code, scan_code,
                                       unicode_char,
                                       is_system_key);
     char_event.skip_in_browser = key_down_text_insertion;
     rwhva_->SendKeyEvent(char_event);
@@ skipping 139 matching lines @@
 WebContents* ImeAdapterAndroid::GetWebContents() {
   RenderWidgetHostImpl* rwh = GetRenderWidgetHostImpl();
   if (!rwh)
     return NULL;
   if (!rwh->IsRenderView())
     return NULL;
   return WebContents::FromRenderViewHost(RenderViewHost::From(rwh));
 }
 
 }  // namespace content