Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: third_party/WebKit/Source/core/frame/UseCounter.cpp

Issue 1378543002: Add UMA for header values in XHR's setRequestHeader() checked against RFC 7230 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reflected tyoshino's comments. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/UseCounter.cpp
diff --git a/third_party/WebKit/Source/core/frame/UseCounter.cpp b/third_party/WebKit/Source/core/frame/UseCounter.cpp
index 9a33c917c57e17f1d88e7e259e0c3038cd87fed9..960641e2c86048c476fcf755581a040eee697a5e 100644
--- a/third_party/WebKit/Source/core/frame/UseCounter.cpp
+++ b/third_party/WebKit/Source/core/frame/UseCounter.cpp
@@ -930,7 +930,10 @@ String UseCounter::deprecationMessage(Feature feature)
return "Request.context is deprecated and will be removed in M46 (see: https://www.chromestatus.com/feature/5534702526005248).";
case HeaderValueNotMatchingRFC7230:
- return "Header values not matching to RFC 7230, will be deprecated (see: https://www.chromestatus.com/feature/6457425448140800).";
+ return "Found a header value that doesn't match the field-content token production (containing invalid octets. see RFC 7230). We are experimenting whether we can throw for such header values (see: https://www.chromestatus.com/feature/6457425448140800).";
+
+ case XHRSetRequestHeaderAffectedByNormalization:
+ return "According to the Fetch Standard, setRequestHeader() must strip leading/trailing whitespaces, but it doesn't currently. We are experimenting whether we can make it conform to the spec (see: https://www.chromestatus.com/feature/6457425448140800). This script will be affected by the change.";
kinuko 2015/09/29 12:51:33 "We are experimenting whether..." the intention of
hiroshige 2015/09/29 13:21:38 "Just experimenting" is somehow accurate: we want
// Features that aren't deprecated don't have a deprecation message.
default:

Powered by Google App Engine
This is Rietveld 408576698