Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Side by Side Diff: third_party/WebKit/Source/core/frame/UseCounter.cpp

Issue 1378543002: Add UMA for header values in XHR's setRequestHeader() checked against RFC 7230 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reflected tyoshino's comments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google, Inc. All rights reserved. 2 * Copyright (C) 2012 Google, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 912 matching lines...) Expand 10 before | Expand all | Expand 10 after
923 case PrefixedPerformanceSetResourceTimingBufferSize: 923 case PrefixedPerformanceSetResourceTimingBufferSize:
924 return replacedBy("Performance.webkitSetResourceTimingBufferSize", "Perf ormance.setResourceTimingBufferSize"); 924 return replacedBy("Performance.webkitSetResourceTimingBufferSize", "Perf ormance.setResourceTimingBufferSize");
925 925
926 case PrefixedPerformanceResourceTimingBufferFull: 926 case PrefixedPerformanceResourceTimingBufferFull:
927 return replacedBy("Performance.onwebkitresourcetimingbufferfull", "Perfo rmance.onresourcetimingbufferfull"); 927 return replacedBy("Performance.onwebkitresourcetimingbufferfull", "Perfo rmance.onresourcetimingbufferfull");
928 928
929 case FetchAPIRequestContext: 929 case FetchAPIRequestContext:
930 return "Request.context is deprecated and will be removed in M46 (see: h ttps://www.chromestatus.com/feature/5534702526005248)."; 930 return "Request.context is deprecated and will be removed in M46 (see: h ttps://www.chromestatus.com/feature/5534702526005248).";
931 931
932 case HeaderValueNotMatchingRFC7230: 932 case HeaderValueNotMatchingRFC7230:
933 return "Header values not matching to RFC 7230, will be deprecated (see: https://www.chromestatus.com/feature/6457425448140800)."; 933 return "Found a header value that doesn't match the field-content token production (containing invalid octets. see RFC 7230). We are experimenting wheth er we can throw for such header values (see: https://www.chromestatus.com/featur e/6457425448140800).";
934
935 case XHRSetRequestHeaderAffectedByNormalization:
936 return "According to the Fetch Standard, setRequestHeader() must strip l eading/trailing whitespaces, but it doesn't currently. We are experimenting whet her we can make it conform to the spec (see: https://www.chromestatus.com/featur e/6457425448140800). This script will be affected by the change.";
kinuko 2015/09/29 12:51:33 "We are experimenting whether..." the intention of
hiroshige 2015/09/29 13:21:38 "Just experimenting" is somehow accurate: we want
934 937
935 // Features that aren't deprecated don't have a deprecation message. 938 // Features that aren't deprecated don't have a deprecation message.
936 default: 939 default:
937 return String(); 940 return String();
938 } 941 }
939 } 942 }
940 943
941 void UseCounter::count(CSSParserContext context, CSSPropertyID feature) 944 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)
942 { 945 {
943 ASSERT(feature >= firstCSSProperty); 946 ASSERT(feature >= firstCSSProperty);
(...skipping 28 matching lines...) Expand all
972 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 975 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
973 { 976 {
974 // FIXME: We may want to handle stylesheets that have multiple owners 977 // FIXME: We may want to handle stylesheets that have multiple owners
975 // http://crbug.com/242125 978 // http://crbug.com/242125
976 if (sheetContents && sheetContents->hasSingleOwnerNode()) 979 if (sheetContents && sheetContents->hasSingleOwnerNode())
977 return getFrom(sheetContents->singleOwnerDocument()); 980 return getFrom(sheetContents->singleOwnerDocument());
978 return 0; 981 return 0;
979 } 982 }
980 983
981 } // namespace blink 984 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698