Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1378533002: [es6] Introduce %ToInteger and %ToLength. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Introduce %ToInteger and %ToLength. This adds ES6 compliant Object::ToInteger, Object::ToInt32, Object::ToUint32 and Object::ToLength, and replaces the old Execution wrappers of those abstract operations (which were not using the correct ToPrimitive). This also introduces proper %ToInteger and %ToLength runtime entries, with a fast path %_ToInteger supported in fullcodegen and Crankshaft (for now). Internal JavaScript code should use TO_INTEGER and TO_LENGTH respectively. CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_layout_dbg,v8_linux_nosnap_dbg BUG=v8:4307 LOG=n Committed: https://crrev.com/93b2b2622ba80d93d036b66736da1346c6e0638c Cr-Commit-Position: refs/heads/master@{#30993}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -167 lines) Patch
M src/accessors.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/api.cc View 6 chunks +7 lines, -8 lines 0 comments Download
M src/builtins.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/contexts.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/execution.h View 1 chunk +0 lines, -17 lines 0 comments Download
M src/execution.cc View 3 chunks +0 lines, -24 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +44 lines, -43 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/globals.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/harmony-array.js View 4 chunks +4 lines, -4 lines 0 comments Download
M src/harmony-array-includes.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/harmony-atomics.js View 11 chunks +15 lines, -15 lines 0 comments Download
M src/hydrogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M src/json.js View 1 chunk +1 line, -1 line 0 comments Download
M src/macros.py View 1 chunk +3 lines, -3 lines 0 comments Download
M src/object-observe.js View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 chunk +16 lines, -0 lines 0 comments Download
M src/objects.cc View 2 chunks +34 lines, -0 lines 0 comments Download
M src/runtime.js View 6 chunks +2 lines, -24 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/runtime/runtime-numbers.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/string.js View 6 chunks +6 lines, -8 lines 0 comments Download
M src/typedarray.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378533002/1
5 years, 2 months ago (2015-09-29 05:28:06 UTC) #2
Benedikt Meurer
Hey Camillo, Here's an easy starter for the day. Please take a look. Thanks, Benedikt
5 years, 2 months ago (2015-09-29 06:40:25 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-29 06:43:01 UTC) #6
Camillo Bruni
lgtm
5 years, 2 months ago (2015-09-29 07:34:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378533002/1
5 years, 2 months ago (2015-09-29 07:39:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 07:41:11 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 07:41:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93b2b2622ba80d93d036b66736da1346c6e0638c
Cr-Commit-Position: refs/heads/master@{#30993}

Powered by Google App Engine
This is Rietveld 408576698