Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1378523003: Devtools[LayoutEditor]: Precise drag with Shift (Closed)

Created:
5 years, 2 months ago by sergeyv
Modified:
5 years, 2 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@medias-every
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Devtools[LayoutEditor]: Precise drag with Shift BUG=501896 Committed: https://crrev.com/d7aa28bbca02d27340bd5472ca4ee5969f98b6bf Cr-Commit-Position: refs/heads/master@{#351710}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorOverlayPage.html View 3 chunks +14 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/LayoutEditor.cpp View 2 chunks +7 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1372963006 Patch 1

Messages

Total messages: 11 (4 generated)
sergeyv
5 years, 2 months ago (2015-09-30 19:10:55 UTC) #2
dgozman
lgtm
5 years, 2 months ago (2015-09-30 19:46:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378523003/1
5 years, 2 months ago (2015-09-30 21:45:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/114657)
5 years, 2 months ago (2015-09-30 23:58:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378523003/1
5 years, 2 months ago (2015-10-01 01:23:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-01 02:43:29 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 02:44:10 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d7aa28bbca02d27340bd5472ca4ee5969f98b6bf
Cr-Commit-Position: refs/heads/master@{#351710}

Powered by Google App Engine
This is Rietveld 408576698