Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1372963006: Devtools[LayoutEditor]: Always show medias in selector tooltip (Closed)

Created:
5 years, 2 months ago by sergeyv
Modified:
5 years, 2 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Devtools[LayoutEditor]: Always show medias in selector tooltip As a driveby: don't allow negative margin. BUG=501896 Committed: https://crrev.com/15297eb2e99a7954fd85375eb2dee57209999858 Cr-Commit-Position: refs/heads/master@{#351648}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -25 lines) Patch
M third_party/WebKit/Source/core/inspector/LayoutEditor.cpp View 3 chunks +8 lines, -25 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (2 generated)
sergeyv
5 years, 2 months ago (2015-09-29 22:39:55 UTC) #2
dgozman
Why would we disallow negative margin?
5 years, 2 months ago (2015-09-29 22:59:32 UTC) #3
pbakaus
On 2015/09/29 at 22:59:32, dgozman wrote: > Why would we disallow negative margin? It's very ...
5 years, 2 months ago (2015-09-30 15:11:22 UTC) #4
dgozman
lgtm
5 years, 2 months ago (2015-09-30 19:16:11 UTC) #5
dgozman
lgtm lgtm
5 years, 2 months ago (2015-09-30 19:16:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372963006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372963006/1
5 years, 2 months ago (2015-09-30 19:54:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 21:40:43 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 21:42:26 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15297eb2e99a7954fd85375eb2dee57209999858
Cr-Commit-Position: refs/heads/master@{#351648}

Powered by Google App Engine
This is Rietveld 408576698