Issue 137843003: Don't pass -D_I386MACH_ALLOW_HW_INTERRUPTS explicitly in newlib build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137843003: Don't pass -D_I386MACH_ALLOW_HW_INTERRUPTS explicitly in newlib build (Closed)

Created:
6 years, 11 months ago by Roland McGrath

Modified:
6 years, 11 months ago

Reviewers:
bradn

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

More Reviews

Description

Don't pass -D_I386MACH_ALLOW_HW_INTERRUPTS explicitly in newlib build This brings in recent newlib changes: cc9ce45 Add -D_I386MACH_ALLOW_HW_INTERRUPTS in configure.host for nacl 489f1d8 Include more of sys/types.h and sys/signal.h under NaCl 02b55a2 Define _POSIX_THREADS under NaCl. The most recent change makes it superfluous to pass the -D switch via configure options, so stop doing that. BUG= cleanup TEST= toolchain trybots R=bradnelson@google.com Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=12635

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -11 lines)			Patch
M	toolchain_build/toolchain_build.py	View	3 chunks	+2 lines, -9 lines	0 comments	Download
M	tools/Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/REVISIONS	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Roland McGrath

6 years, 11 months ago (2014-01-17 23:35:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r12635 (presubmit successful).

Expand Messages | Collapse Messages