Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: toolchain_build/toolchain_build.py

Issue 137843003: Don't pass -D_I386MACH_ALLOW_HW_INTERRUPTS explicitly in newlib build (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/Makefile » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: toolchain_build/toolchain_build.py
diff --git a/toolchain_build/toolchain_build.py b/toolchain_build/toolchain_build.py
index e99a7d8ec7ae07fda4a794ef797193611246bd89..10688e7d56d977c2e0ed5e2965748f1f832721a9 100755
--- a/toolchain_build/toolchain_build.py
+++ b/toolchain_build/toolchain_build.py
@@ -23,7 +23,7 @@ NACL_DIR = os.path.dirname(SCRIPT_DIR)
GIT_REVISIONS = {
'binutils': '38dbda270a4248ab5b7facc012b9c8d8527f6fb2',
'gcc': '145a627d95b98f54915d037dddbcbb0f7b283494',
- 'newlib': '9f95ad0b4875d153b9d138090e61ac4c24e9a87d',
+ 'newlib': 'cc9ce45891a45ecfbc671f4a6f1b06ba60a55ad9',
}
TAR_FILES = {
@@ -615,13 +615,6 @@ def CommonTargetCflags(target):
return options
-def NewlibTargetCflags(target):
- options = CommonTargetCflags(target) + [
- '-D_I386MACH_ALLOW_HW_INTERRUPTS',
- ]
- return ' '.join(options)
-
-
def TargetCommands(host, target, command_list):
# First we have to copy the host tools into a common directory.
# We can't just have both directories in our PATH, because the
@@ -660,7 +653,7 @@ def TargetLibs(host, target):
'--enable-newlib-io-c99-formats',
'--enable-newlib-mb',
'CFLAGS=-O2',
- 'CFLAGS_FOR_TARGET=' + NewlibTargetCflags(target),
+ 'CFLAGS_FOR_TARGET=' + ' '.join(CommonTargetCflags(target)),
'INSTALL_DATA=' + newlib_install_data,
]
« no previous file with comments | « no previous file | tools/Makefile » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698