Do some plumbing.

Do some plumbing.

* Move execution options for native apps into its own independent
  struct (rather than be NativeRunnerFactory::Options).
* Plumb this all the way down, using it appropriately (this requires
  adding fields to the options struct).
* E.g., require_32_bit is now one of the options.
* In ApplicationManager, replace SetNativeOptionsForURL() with something
  that returns a (non-const) reference to the options struct for the
  give URL. This is useful since we sometimes want to fiddle with
  various options independently.
* Add a "allow_new_privs" option. When running in multiprocess, we may
  or may not want the child to acquire new privileges (typically not,
  but sometimes -- e.g., without it, you can't run sudo/screen/other
  setuid programs through mojo:native_support).
* Hack in hardcoded support to set allow_new_privs for
  mojo:native_support.
* In general, we need a better, more complete, more consistent way of
  setting options for native apps (e.g., sandboxing options).

R=vardhan@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/64bb17c85985e4f6e2b3311dcf78fc7d2c520958

[vardhan, 2015-10-02 23:18:35]

lgtm w/ small comment

https://codereview.chromium.org/1378303005/diff/1/shell/application_manager/a...
File shell/application_manager/application_manager.cc (right):

https://codereview.chromium.org/1378303005/diff/1/shell/application_manager/a...
shell/application_manager/application_manager.cc:451: NativeApplicationOptions&
ApplicationManager::NativeApplicationOptionsForURL(
Seems like this is configuring the 'default' options and returning a reference
to it (which you later use to modify the options), is that correct?

If so, should this instead return a pointer (to denote that it's mutable)?
And what about calling this MakeNativeApplicationOptionsForUrl?

feel free to ignore tho

[viettrungluu, 2015-10-03 00:01:47]

Thanks.

On 2015/10/02 23:18:35, vardhan wrote:
> lgtm w/ small comment
> 
>
https://codereview.chromium.org/1378303005/diff/1/shell/application_manager/a...
> File shell/application_manager/application_manager.cc (right):
> 
>
https://codereview.chromium.org/1378303005/diff/1/shell/application_manager/a...
> shell/application_manager/application_manager.cc:451:
NativeApplicationOptions&
> ApplicationManager::NativeApplicationOptionsForURL(
> Seems like this is configuring the 'default' options and returning a reference
> to it (which you later use to modify the options), is that correct?
> 
> If so, should this instead return a pointer (to denote that it's mutable)?
> And what about calling this MakeNativeApplicationOptionsForUrl?
> 
> feel free to ignore tho

I made it return a pointer.

I called it Get...(), since it "Make" isn't really right.

[viettrungluu, 2015-10-03 00:02:08]

Committed patchset #2 (id:20001) manually as
64bb17c85985e4f6e2b3311dcf78fc7d2c520958 (presubmit successful).