Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: shell/application_manager/native_runner.h

Issue 1378303005: Do some plumbing. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: review Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « shell/application_manager/native_application_options.h ('k') | shell/child_process_host.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SHELL_APPLICATION_MANAGER_NATIVE_RUNNER_H_ 5 #ifndef SHELL_APPLICATION_MANAGER_NATIVE_RUNNER_H_
6 #define SHELL_APPLICATION_MANAGER_NATIVE_RUNNER_H_ 6 #define SHELL_APPLICATION_MANAGER_NATIVE_RUNNER_H_
7 7
8 #include "base/callback_forward.h" 8 #include "base/callback_forward.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "mojo/public/cpp/bindings/interface_request.h" 10 #include "mojo/public/cpp/bindings/interface_request.h"
11 #include "mojo/public/interfaces/application/application.mojom.h" 11 #include "mojo/public/interfaces/application/application.mojom.h"
12 #include "shell/native_application_support.h" 12 #include "shell/native_application_support.h"
13 13
14 namespace base { 14 namespace base {
15 class FilePath; 15 class FilePath;
16 } 16 }
17 17
18 namespace shell { 18 namespace shell {
19 19
20 struct NativeApplicationOptions;
21
20 // ApplicationManager requires implementations of NativeRunner and 22 // ApplicationManager requires implementations of NativeRunner and
21 // NativeRunnerFactory to run native applications. 23 // NativeRunnerFactory to run native applications.
22 class NativeRunner { 24 class NativeRunner {
23 public: 25 public:
24 virtual ~NativeRunner() {} 26 virtual ~NativeRunner() {}
25 27
26 // Loads the app in the file at |app_path| and runs it on some other 28 // Loads the app in the file at |app_path| and runs it on some other
27 // thread/process. 29 // thread/process.
28 // |app_completed_callback| is posted (to the thread on which |Start()| was 30 // |app_completed_callback| is posted (to the thread on which |Start()| was
29 // called) after |MojoMain()| completes, or on any error (including if it 31 // called) after |MojoMain()| completes, or on any error (including if it
30 // fails to start). 32 // fails to start).
31 // TODO(vtl): |app_path| should probably be moved to the factory's Create(). 33 // TODO(vtl): |app_path| should probably be moved to the factory's Create().
32 // Rationale: The factory may need information from the file to decide what 34 // Rationale: The factory may need information from the file to decide what
33 // kind of NativeRunner to make. 35 // kind of NativeRunner to make.
34 virtual void Start( 36 virtual void Start(
35 const base::FilePath& app_path, 37 const base::FilePath& app_path,
36 mojo::InterfaceRequest<mojo::Application> application_request, 38 mojo::InterfaceRequest<mojo::Application> application_request,
37 const base::Closure& app_completed_callback) = 0; 39 const base::Closure& app_completed_callback) = 0;
38 }; 40 };
39 41
40 class NativeRunnerFactory { 42 class NativeRunnerFactory {
41 public: 43 public:
42 // Options for running the native app. (This will contain, e.g., information
43 // about the sandbox profile, etc.)
44 struct Options {
45 // Constructs with default options.
46 Options() : force_in_process(false) {}
47
48 bool force_in_process;
49 };
50
51 virtual ~NativeRunnerFactory() {} 44 virtual ~NativeRunnerFactory() {}
52 virtual scoped_ptr<NativeRunner> Create(const Options& options) = 0; 45 virtual scoped_ptr<NativeRunner> Create(
46 const NativeApplicationOptions& options) = 0;
53 }; 47 };
54 48
55 } // namespace shell 49 } // namespace shell
56 50
57 #endif // SHELL_APPLICATION_MANAGER_NATIVE_RUNNER_H_ 51 #endif // SHELL_APPLICATION_MANAGER_NATIVE_RUNNER_H_
OLDNEW
« no previous file with comments | « shell/application_manager/native_application_options.h ('k') | shell/child_process_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698