Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1378203002: Handle hosted apps consistently in --isolate-extensions. (Closed)

Created:
5 years, 2 months ago by ncarter (slow)
Modified:
5 years, 2 months ago
Reviewers:
Charlie Reis, jam
CC:
chromium-reviews, darin-cc_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle hosted apps consistently in --isolate-extensions. Ultimately, we want hosted apps not to be isolated by --isolate-extensions. However, the current implementation was excluding them from isolation by accident, because we weren't looking up the effective url. As a result, we were inconstent: app.com(web.com) was 2 processes, but web.com(app.com) was one process. This CL fixes the inconsistency, and fixes a test TODO where we noticed the problem. TBR=jam@chromium.org BUG=535073 TEST=browser_tests with --isolate-extensions (the bots don't run this yet) Committed: https://crrev.com/8a1a0feb26645f14fe00618493d9364b004eea7a Cr-Commit-Position: refs/heads/master@{#351829}

Patch Set 1 #

Messages

Total messages: 10 (3 generated)
ncarter (slow)
5 years, 2 months ago (2015-09-30 22:32:28 UTC) #2
Charlie Reis
LGTM. (While in one sense we're moving backwards and don't want to isolate hosted apps ...
5 years, 2 months ago (2015-09-30 23:01:01 UTC) #3
ncarter (slow)
TBRing jam (one line test expectation fix in chrome/)
5 years, 2 months ago (2015-10-01 16:44:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378203002/1
5 years, 2 months ago (2015-10-01 16:45:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-01 17:14:20 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8a1a0feb26645f14fe00618493d9364b004eea7a Cr-Commit-Position: refs/heads/master@{#351829}
5 years, 2 months ago (2015-10-01 17:15:17 UTC) #9
jam
5 years, 2 months ago (2015-10-02 17:04:14 UTC) #10
Message was sent while issue was closed.
On 2015/10/01 16:44:11, ncarter wrote:
> TBRing jam (one line test expectation fix in chrome/)

lgtm

you should add the site isolation folks as owners for that file

Powered by Google App Engine
This is Rietveld 408576698