chrome/browser/site_details_browsertest.cc - Issue 1378203002: Handle hosted apps consistently in --isolate-extensions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/site_details_browsertest.cc

Issue 1378203002: Handle hosted apps consistently in --isolate-extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | content/browser/loader/cross_site_resource_handler.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/site_details.h"	5 #include "chrome/browser/site_details.h"

6	6

7 #include "base/bind_helpers.h"	7 #include "base/bind_helpers.h"

8 #include "base/files/file_path.h"	8 #include "base/files/file_path.h"

9 #include "base/message_loop/message_loop.h"	9 #include "base/message_loop/message_loop.h"

10 #include "base/path_service.h"	10 #include "base/path_service.h"

(...skipping 753 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
764 EXPECT_THAT(details->uma()->GetAllSamples(	764 EXPECT_THAT(details->uma()->GetAllSamples(

765 "SiteIsolation.IsolateExtensionsProcessCountEstimate"),	765 "SiteIsolation.IsolateExtensionsProcessCountEstimate"),

766 ElementsAre(Bucket(2, 1)));	766 ElementsAre(Bucket(2, 1)));

767 EXPECT_THAT(details->uma()->GetAllSamples(	767 EXPECT_THAT(details->uma()->GetAllSamples(

768 "SiteIsolation.IsolateExtensionsProcessCountLowerBound"),	768 "SiteIsolation.IsolateExtensionsProcessCountLowerBound"),

769 ElementsAre(Bucket(2, 1)));	769 ElementsAre(Bucket(2, 1)));

770 EXPECT_THAT(details->uma()->GetAllSamples(	770 EXPECT_THAT(details->uma()->GetAllSamples(

771 "SiteIsolation.IsolateExtensionsProcessCountNoLimit"),	771 "SiteIsolation.IsolateExtensionsProcessCountNoLimit"),

772 ElementsAre(Bucket(2, 1)));	772 ElementsAre(Bucket(2, 1)));

773	773

774 // TODO(nick): http://crbug.com/535073 ought to mean that the next line is 2.	774 EXPECT_THAT(GetRenderProcessCount(), EqualsIfExtensionsIsolated(2));

775 // But it's actually 1. Figure out why.

776 EXPECT_THAT(GetRenderProcessCount(), EqualsIfExtensionsIsolated(1));

777 }	775 }

OLD	NEW