Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 137813004: Multiple selectors setting relative font-weight names to an element result in a cumulative result (Closed)

Created:
6 years, 10 months ago by rwlbuis
Modified:
6 years, 10 months ago
Reviewers:
eae, rune
CC:
blink-reviews, dglazkov+blink, rune+blink, apavlov+blink_chromium.org, ed+blinkwatch_opera.com, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Multiple selectors setting relative font-weight names to an element result in a cumulative result According to http://dev.w3.org/csswg/css-fonts/#font-weight-prop, the computed weight of 'lighter' and 'bolder' are based on the inherited 'font-weight', so set that inherited weight before calculating 'lighter' and 'bolder'. BUG=322032 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166795

Patch Set 1 #

Patch Set 2 : Add testcase #

Total comments: 1

Patch Set 3 : Improve testcase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
A + LayoutTests/css3/font-weight-multiple-selectors.html View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
A + LayoutTests/css3/font-weight-multiple-selectors-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rwlbuis
A fix to make font-weight compliant with the spec in the case of lighter/bolder and ...
6 years, 10 months ago (2014-02-07 21:00:45 UTC) #1
rune
lgtm (non-reviewer) Please modify the description to have lines < 80 characters. The side-by-side diffs ...
6 years, 10 months ago (2014-02-07 22:37:11 UTC) #2
rwlbuis
Hi Rune, On 2014/02/07 22:37:11, rune - CET wrote: > lgtm (non-reviewer) > > Please ...
6 years, 10 months ago (2014-02-07 22:42:59 UTC) #3
rwlbuis
Bots are all green, ready for review :)
6 years, 10 months ago (2014-02-08 01:41:31 UTC) #4
eae
LGTM Thanks!
6 years, 10 months ago (2014-02-10 00:08:55 UTC) #5
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 10 months ago (2014-02-10 03:06:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/137813004/210001
6 years, 10 months ago (2014-02-10 03:06:12 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-10 03:59:51 UTC) #8
Message was sent while issue was closed.
Change committed as 166795

Powered by Google App Engine
This is Rietveld 408576698