Multiple selectors setting relative font-weight names to an element result in a cumulative result

Multiple selectors setting relative font-weight names to an element result in a cumulative result

According to http://dev.w3.org/csswg/css-fonts/#font-weight-prop, the computed
weight of 'lighter' and 'bolder' are based on the inherited 'font-weight', so set
that inherited weight before calculating 'lighter' and 'bolder'.

BUG=322032
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166795

[rwlbuis, 2014-02-07 21:00:45]

A fix to make font-weight compliant with the spec in the case of lighter/bolder
and also add a testcase. Let me know if you think you are not the correct one to
review.

[rune, 2014-02-07 22:37:11]

lgtm (non-reviewer)

Please modify the description to have lines < 80 characters.

The side-by-side diffs are broken. When that happens, you can try another "git
cl upload". When adding new files, you can do "git cl upload --no-find-copies"
instead of getting a diff against a similar file.

https://codereview.chromium.org/137813004/diff/40001/LayoutTests/css3/font-we...
File LayoutTests/css3/font-weight-multiple-selectors.html (right):

https://codereview.chromium.org/137813004/diff/40001/LayoutTests/css3/font-we...
LayoutTests/css3/font-weight-multiple-selectors.html:13: </div>

You could use id selectors instead and remove the class attributes above.

[rwlbuis, 2014-02-07 22:42:59]

Hi Rune,

On 2014/02/07 22:37:11, rune - CET wrote:
> lgtm (non-reviewer)
> 
> Please modify the description to have lines < 80 characters.
> 
> The side-by-side diffs are broken. When that happens, you can try another "git
> cl upload". When adding new files, you can do "git cl upload --no-find-copies"
> instead of getting a diff against a similar file.
> 
>
https://codereview.chromium.org/137813004/diff/40001/LayoutTests/css3/font-we...
> File LayoutTests/css3/font-weight-multiple-selectors.html (right):
> 
>
https://codereview.chromium.org/137813004/diff/40001/LayoutTests/css3/font-we...
> LayoutTests/css3/font-weight-multiple-selectors.html:13: </div>
> 
> You could use id selectors instead and remove the class attributes above.

Thanks for the feedback! I didn't notice the upload problem... Will try to fix
your issues mentioned above.

[rwlbuis, 2014-02-08 01:41:31]

Bots are all green, ready for review :)

[eae, 2014-02-10 00:08:55]

LGTM

Thanks!

[rwlbuis, 2014-02-10 03:06:05]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-02-10 03:06:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/137813004/210001

[commit-bot: I haz the power, 2014-02-10 03:59:51]

Change committed as 166795